You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/11 06:04:09 UTC

[GitHub] [apisix-helm-chart] tao12345666333 opened a new pull request #233: fix: enable stream_route mode when ingress enabled

tao12345666333 opened a new pull request #233:
URL: https://github.com/apache/apisix-helm-chart/pull/233


   Since the release of APISIX v2.12, we found that when using Helm chart to install both APISIX and Ingress controller, the Ingress controller does not work properly.
   
   This is because the stream_route mode is disabled by default in APISIX, but it is required by the Ingress controller.
   
   xref:
   issue: https://github.com/apache/apisix-ingress-controller/issues/851#issuecomment-1026306420
   https://github.com/apache/apisix-ingress-controller/issues/858
   
   Another fix on the APISIX Ingress controller is tracked at https://github.com/apache/apisix-ingress-controller/issues/856


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #233: fix: enable stream_route mode when ingress enabled

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #233:
URL: https://github.com/apache/apisix-helm-chart/pull/233#issuecomment-1035913059


   This is a serious problem, we need an upgrade version to release it immediately.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #233: fix: enable stream_route mode when ingress enabled

Posted by GitBox <gi...@apache.org>.
tao12345666333 merged pull request #233:
URL: https://github.com/apache/apisix-helm-chart/pull/233


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #233: fix: enable stream_route mode when ingress enabled

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #233:
URL: https://github.com/apache/apisix-helm-chart/pull/233#issuecomment-1035915070


   > Maybe we should update both Deployment and Service as well.
   
   Why? This is for compatibility with Ingress controller behavior only, not for APISIX users. If the user really needs to expose stream_route, then modify the corresponding configuration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-helm-chart] Gallardot commented on pull request #233: fix: enable stream_route mode when ingress enabled

Posted by GitBox <gi...@apache.org>.
Gallardot commented on pull request #233:
URL: https://github.com/apache/apisix-helm-chart/pull/233#issuecomment-1035914025


   Maybe we should update both Deployment and Service as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-helm-chart] Gallardot commented on pull request #233: fix: enable stream_route mode when ingress enabled

Posted by GitBox <gi...@apache.org>.
Gallardot commented on pull request #233:
URL: https://github.com/apache/apisix-helm-chart/pull/233#issuecomment-1035916092


   
   > Why? This is for compatibility with Ingress controller behavior only, not for APISIX users. If the user really needs to expose stream_route, then modify the corresponding configuration.
   
   Okay, got it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org