You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shiro.apache.org by GitBox <gi...@apache.org> on 2019/05/28 16:59:10 UTC

[GitHub] [shiro] fpapon commented on a change in pull request #137: Build

fpapon commented on a change in pull request #137: Build
URL: https://github.com/apache/shiro/pull/137#discussion_r288206310
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -1474,5 +1478,54 @@
                 </plugins>
             </build>
         </profile>
+        <profile>
+            <id>samples</id>
+            <modules>
+                <module>samples</module>
+            </modules>
+        </profile>
+        <profile>
+            <id>rat</id>
+            <modules>
+                <module>integration-tests</module>
+                <module>test-coverage</module>
+                <module>samples</module>
+            </modules>
+            <build>
+                <defaultGoal>apache-rat:check</defaultGoal>
+                <plugins>
+                    <plugin>
+                        <groupId>org.apache.rat</groupId>
+                        <artifactId>apache-rat-plugin</artifactId>
+                        <version>0.12</version>
+                        <!-- only run at the root -->
+                        <inherited>false</inherited>
+                        <executions>
+                            <execution>
+                                <phase>verify</phase>
+                                <goals>
+                                    <goal>check</goal>
+                                </goals>
+                            </execution>
+                        </executions>
+                        <configuration>
 
 Review comment:
   I add a rat profile because I move some module out of the default build, so the plugin failed to scan them. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services