[GitHub] [incubator-doris] infearOnTheWay commented on issue #2603: Add nio support for mysql protocol implementation

[GitBox <gi...@apache.org>]

infearOnTheWay commented on issue #2603: Add nio support for mysql protocol implementation
URL: https://github.com/apache/incubator-doris/pull/2603#issuecomment-570495207
 
 
   Since the idle check is still use connect scheduler, so *submit *is just
   retained.
   Sorry for too late reply for this mail, since I don't find the relative
   conversation on my pr any more......
   
   On Fri, Dec 27, 2019 at 10:47 PM Mingyu Chen <no...@github.com>
   wrote:
   
   > *@morningman* commented on this pull request.
   > ------------------------------
   >
   > In fe/src/main/java/org/apache/doris/mysql/nio/AcceptListener.java
   > <https://github.com/apache/incubator-doris/pull/2603#discussion_r361679254>
   > :
   >
   > > +
   > +    public AcceptListener(ConnectScheduler connectScheduler) {
   > +        this.connectScheduler = connectScheduler;
   > +    }
   > +
   > +    @Override
   > +    public void handleEvent(AcceptingChannel<StreamConnection> channel) {
   > +        try {
   > +            StreamConnection connection = channel.accept();
   > +            if (connection == null) {
   > +                return;
   > +            }
   > +            LOG.info("Connection established. remote={}", connection.getPeerAddress());
   > +            NConnectContext context = new NConnectContext(connection);
   > +            context.setCatalog(Catalog.getInstance());
   > +            connectScheduler.submit(context);
   >
   > Does connectScheduler.submit(context); still needed here?
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-doris/pull/2603?email_source=notifications&email_token=AE5SSTZHNHERTO3SWR4NSILQ2YIRRA5CNFSM4J7ZIRM2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQJQD2Y#pullrequestreview-336789995>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AE5SSTZFFCG4IFPHZKMS4PDQ2YIRRANCNFSM4J7ZIRMQ>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org