Re: [PR] CASSANDRA-19472 - CEP-15 (C*) Integrate accord with repair [cassandra]

["bdeggleston (via GitHub)" <gi...@apache.org>]

bdeggleston commented on code in PR #3174:
URL: https://github.com/apache/cassandra/pull/3174#discussion_r1548323325


##########
src/java/org/apache/cassandra/service/accord/repair/AccordRepair.java:
##########
@@ -150,20 +179,17 @@ private void repairRange(TokenRange range) throws Throwable
             }
             catch (RuntimeException e)
             {
-                // TODO Placeholder for dependency limit overflow
-//                dependencyOverflow = true;
-                cfs.metric.rangeMigrationDependencyLimitFailures.mark();

Review Comment:
   I'd initially intended to keep accord migration and normal accord repairs separate, which didn't end up making sense. I'll rename and restore the metrics



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org