You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@annotator.apache.org by GitBox <gi...@apache.org> on 2020/04/03 01:31:48 UTC
[GitHub] [incubator-annotator] tilgovi opened a new pull request #71: Remove
fragment-identifier package
tilgovi opened a new pull request #71: Remove fragment-identifier package
URL: https://github.com/apache/incubator-annotator/pull/71
Due to unresolved questions about the fragment identifier format and
difficulties around parsing the fragment identifier correctly, remove
the fragment-identifier package entirely for the time being.
See also [w3c/web-annotation#443].
Close #66.
[w3c/web-annotation#443]: https://github.com/w3c/web-annotation/issues/443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-annotator] tilgovi commented on issue #71: Remove
fragment-identifier package
Posted by GitBox <gi...@apache.org>.
tilgovi commented on issue #71: Remove fragment-identifier package
URL: https://github.com/apache/incubator-annotator/pull/71#issuecomment-608478918
Excellent! Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-annotator] tilgovi merged pull request #71: Remove
fragment-identifier package
Posted by GitBox <gi...@apache.org>.
tilgovi merged pull request #71: Remove fragment-identifier package
URL: https://github.com/apache/incubator-annotator/pull/71
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-annotator] Treora commented on issue #71: Remove
fragment-identifier package
Posted by GitBox <gi...@apache.org>.
Treora commented on issue #71: Remove fragment-identifier package
URL: https://github.com/apache/incubator-annotator/pull/71#issuecomment-608413746
And fantastic that you made work of this right away!
I did however plan to first merge the tests and tweaks I did yesterday, in order to keep them available in our history (without having a dead branch linger around forever).
I will just merge those additions first, then we can remove them again while merging this. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-annotator] Treora commented on issue #71: Remove
fragment-identifier package
Posted by GitBox <gi...@apache.org>.
Treora commented on issue #71: Remove fragment-identifier package
URL: https://github.com/apache/incubator-annotator/pull/71#issuecomment-608422127
To resolve merge conflicts already, I rebased onto master and force-pushed this PR. Hope that’s okay!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services