[GitHub] [pinot] abhioncbr commented on pull request #10990: Updated code for setting value of segment min/max property.

["abhioncbr (via GitHub)" <gi...@apache.org>]

abhioncbr commented on PR #10990:
URL: https://github.com/apache/pinot/pull/10990#issuecomment-1622191369

   > This is incorrect because after modifying the value it is no longer the min/max value and can cause wrong result. E.g. ` zzz` can be the min value because of the leading whitespace, but after removing the whitespace it will be changed to `zzz` which is a very large value. We need to handle min/max value separately, and ensure the modified value is smaller than min/larger than max.
   
   Question: why do the min/max values with leading or trailing ` ` or with `,` are invalid? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org