You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/04 15:57:19 UTC
[GitHub] [airflow] OyinOlamide opened a new pull request #19406: Shell edits
OyinOlamide opened a new pull request #19406:
URL: https://github.com/apache/airflow/pull/19406
Hi @potiuk So I tried my hands on the better variable naming issue, I do not think this PR is perfect, I would however like corrections, what I have done wrong and can do so I can make better changes and get the entire issue solved.
Thank you!
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #19406: Shell edits
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #19406:
URL: https://github.com/apache/airflow/pull/19406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] OyinOlamide commented on pull request #19406: Shell edits
Posted by GitBox <gi...@apache.org>.
OyinOlamide commented on pull request #19406:
URL: https://github.com/apache/airflow/pull/19406#issuecomment-970348519
> You really need to start from the latest main and resolve conflicts, I am afraid.
Hi @potiuk , I opened a new, clean PR which can be found here, https://github.com/apache/airflow/pull/19577
With your approval, I would like to close this one so the new one can be the focus. Looking to hear from you. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #19406: Shell edits
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #19406:
URL: https://github.com/apache/airflow/pull/19406#issuecomment-964320033
> Hi @potiuk Thanks for your feedback. I'd like to know. I have already submitted the PR link on Outreachy, do I need to delete the entire PR or is there a way I can go about removing the unnecessary commits in the PR?
You can remove the changes in your file, commit them, rebase and push
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] OyinOlamide commented on pull request #19406: Shell edits
Posted by GitBox <gi...@apache.org>.
OyinOlamide commented on pull request #19406:
URL: https://github.com/apache/airflow/pull/19406#issuecomment-961188137
Hello @eladkal @ephraimbuddy This is my second PR and first try on the better naming conventions issue.
Please let me know what I may have done wrong or need to improve on so as to make better changes and get the entire issue solved.
Thank you. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19406: Shell edits
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19406:
URL: https://github.com/apache/airflow/pull/19406#issuecomment-1003470775
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19406: Shell edits
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19406:
URL: https://github.com/apache/airflow/pull/19406#issuecomment-968365641
You really need to start from the latest main and resolve conflicts, I am afraid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19406: Shell edits
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19406:
URL: https://github.com/apache/airflow/pull/19406#issuecomment-962671111
> Please let me know what I may have done wrong or need to improve on so as to make better changes and get the entire issue solved.
Sorry for missing that one - but you will need to rebase and remove the chagnes from INSTALL/Quick start as they were already updated in the meantime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] OyinOlamide commented on pull request #19406: Shell edits
Posted by GitBox <gi...@apache.org>.
OyinOlamide commented on pull request #19406:
URL: https://github.com/apache/airflow/pull/19406#issuecomment-964220903
Hi @potiuk Thanks for your feedback. I'd like to know. I have already submitted the PR link on Outreachy, do I need to delete the entire PR or is there a way I can go about removing the unnecessary commits in the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] OyinOlamide commented on pull request #19406: Shell edits
Posted by GitBox <gi...@apache.org>.
OyinOlamide commented on pull request #19406:
URL: https://github.com/apache/airflow/pull/19406#issuecomment-966187505
Thank you @ephraimbuddy I'll do that today and get back to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org