You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by ro...@apache.org on 2021/11/01 19:55:21 UTC

[activemq-artemis] branch main updated: ARTEMIS-3363: add a couple of assertions for completeness (+fix deprecation warning)

This is an automated email from the ASF dual-hosted git repository.

robbie pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git


The following commit(s) were added to refs/heads/main by this push:
     new ea8fe11  ARTEMIS-3363: add a couple of assertions for completeness (+fix deprecation warning)
ea8fe11 is described below

commit ea8fe11c6d60dc9857544b41bbd1e00d9ae1a9a4
Author: Robbie Gemmell <ro...@apache.org>
AuthorDate: Thu Oct 28 14:35:15 2021 +0100

    ARTEMIS-3363: add a couple of assertions for completeness (+fix deprecation warning)
---
 .../activemq/artemis/api/core/TransportConfigurationTest.java      | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/artemis-core-client/src/test/java/org/apache/activemq/artemis/api/core/TransportConfigurationTest.java b/artemis-core-client/src/test/java/org/apache/activemq/artemis/api/core/TransportConfigurationTest.java
index bb39418..ecbd426 100644
--- a/artemis-core-client/src/test/java/org/apache/activemq/artemis/api/core/TransportConfigurationTest.java
+++ b/artemis-core-client/src/test/java/org/apache/activemq/artemis/api/core/TransportConfigurationTest.java
@@ -29,6 +29,7 @@ import org.junit.Test;
 
 import static org.hamcrest.CoreMatchers.containsString;
 import static org.hamcrest.CoreMatchers.not;
+import static org.hamcrest.MatcherAssert.assertThat;
 
 public class TransportConfigurationTest {
 
@@ -82,7 +83,9 @@ public class TransportConfigurationTest {
 
       Assert.assertNotEquals(new TransportConfiguration(className, params, name, null), new TransportConfiguration(className, params, name, extraParams));
       Assert.assertNotEquals(new TransportConfiguration(className, params, name, Collections.emptyMap()), new TransportConfiguration(className, params, name, extraParams));
-      Assert.assertNotEquals(new TransportConfiguration(className, params, name, extraParams), new TransportConfiguration(className, params, name, Collections.singletonMap("key", "too")));
+      Assert.assertNotEquals(new TransportConfiguration(className, params, name, extraParams), new TransportConfiguration(className, params, name, Collections.singletonMap("key", "other")));
+      Assert.assertNotEquals(new TransportConfiguration(className, params, name, extraParams), new TransportConfiguration(className, params, name, null));
+      Assert.assertNotEquals(new TransportConfiguration(className, params, name, extraParams), new TransportConfiguration(className, params, name, Collections.emptyMap()));
    }
 
    @Test
@@ -93,7 +96,7 @@ public class TransportConfigurationTest {
 
       TransportConfiguration configuration = new TransportConfiguration("SomeClass", params, null);
 
-      Assert.assertThat(configuration.toString(), not(containsString("secret_password")));
+      assertThat(configuration.toString(), not(containsString("secret_password")));
    }
 
    @Test