You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/07/05 00:31:18 UTC
[GitHub] [iceberg] rdblue opened a new pull request #1168: Add JDK 11 to CI build, disable Spark 2.4 with JDK 11
rdblue opened a new pull request #1168:
URL: https://github.com/apache/iceberg/pull/1168
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdsr commented on a change in pull request #1168: Add JDK 11 to CI build, disable Spark 2.4 with JDK 11
Posted by GitBox <gi...@apache.org>.
rdsr commented on a change in pull request #1168:
URL: https://github.com/apache/iceberg/pull/1168#discussion_r449850462
##########
File path: settings.gradle
##########
@@ -47,10 +45,15 @@ project(':arrow').name = 'iceberg-arrow'
project(':parquet').name = 'iceberg-parquet'
project(':bundled-guava').name = 'iceberg-bundled-guava'
project(':spark').name = 'iceberg-spark'
-project(':spark2').name = 'iceberg-spark2'
-project(':spark-runtime').name = 'iceberg-spark-runtime'
project(':spark3').name = 'iceberg-spark3'
project(':spark3-runtime').name = 'iceberg-spark3-runtime'
project(':pig').name = 'iceberg-pig'
project(':hive').name = 'iceberg-hive'
+if (JavaVersion.current() == JavaVersion.VERSION_1_8) {
Review comment:
Does this mean that we do not publish spark2 artifacts when building using Java 11?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue edited a comment on pull request #1168: Add JDK 11 to CI build, disable Spark 2.4 with JDK 11
Posted by GitBox <gi...@apache.org>.
rdblue edited a comment on pull request #1168:
URL: https://github.com/apache/iceberg/pull/1168#issuecomment-654321227
Thanks for the reviews, @rdsr & @jun-he!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdsr commented on a change in pull request #1168: Add JDK 11 to CI build, disable Spark 2.4 with JDK 11
Posted by GitBox <gi...@apache.org>.
rdsr commented on a change in pull request #1168:
URL: https://github.com/apache/iceberg/pull/1168#discussion_r449940034
##########
File path: settings.gradle
##########
@@ -47,10 +45,15 @@ project(':arrow').name = 'iceberg-arrow'
project(':parquet').name = 'iceberg-parquet'
project(':bundled-guava').name = 'iceberg-bundled-guava'
project(':spark').name = 'iceberg-spark'
-project(':spark2').name = 'iceberg-spark2'
-project(':spark-runtime').name = 'iceberg-spark-runtime'
project(':spark3').name = 'iceberg-spark3'
project(':spark3-runtime').name = 'iceberg-spark3-runtime'
project(':pig').name = 'iceberg-pig'
project(':hive').name = 'iceberg-hive'
+if (JavaVersion.current() == JavaVersion.VERSION_1_8) {
Review comment:
Thks. That makes sense!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1168: Add JDK 11 to CI build, disable Spark 2.4 with JDK 11
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1168:
URL: https://github.com/apache/iceberg/pull/1168#issuecomment-654321227
Thanks for the reviews, @rdsdr & @jun-he!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #1168: Add JDK 11 to CI build, disable Spark 2.4 with JDK 11
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1168:
URL: https://github.com/apache/iceberg/pull/1168
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #1168: Add JDK 11 to CI build, disable Spark 2.4 with JDK 11
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #1168:
URL: https://github.com/apache/iceberg/pull/1168#discussion_r449915554
##########
File path: settings.gradle
##########
@@ -47,10 +45,15 @@ project(':arrow').name = 'iceberg-arrow'
project(':parquet').name = 'iceberg-parquet'
project(':bundled-guava').name = 'iceberg-bundled-guava'
project(':spark').name = 'iceberg-spark'
-project(':spark2').name = 'iceberg-spark2'
-project(':spark-runtime').name = 'iceberg-spark-runtime'
project(':spark3').name = 'iceberg-spark3'
project(':spark3-runtime').name = 'iceberg-spark3-runtime'
project(':pig').name = 'iceberg-pig'
project(':hive').name = 'iceberg-hive'
+if (JavaVersion.current() == JavaVersion.VERSION_1_8) {
Review comment:
Release builds are built with Java 8 and should run fine in Java 11. We just can't run the Spark 2.x tests in Java 11 because those versions of Spark are incompatible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org