You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "henry3260 (via GitHub)" <gi...@apache.org> on 2025/12/15 06:01:33 UTC
[PR] Remove Legacy Query Object Usage from test_dag_bundle_manager.py [airflow]
henry3260 opened a new pull request, #59424:
URL: https://github.com/apache/airflow/pull/59424
related: #59402
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove Legacy Query Object Usage from test_dag_bundle_manager.py [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on code in PR #59424:
URL: https://github.com/apache/airflow/pull/59424#discussion_r2618085516
##########
.pre-commit-config.yaml:
##########
@@ -412,7 +412,7 @@ repos:
(?x)
^airflow-ctl.*\.py$|
^airflow-core/src/airflow/models/.*\.py$|
- ^airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_assets.py$|
+ ^airflow-core/tests/unit/dag_processing/bundles/test_dag_bundle_manager.py$|
Review Comment:
`test_assets.py` seems to be removed accidentally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove Legacy Query Object Usage from test_dag_bundle_manager.py [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on PR #59424:
URL: https://github.com/apache/airflow/pull/59424#issuecomment-3653670103
Goood :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove Legacy Query Object Usage from test_dag_bundle_manager.py [airflow]
Posted by "henry3260 (via GitHub)" <gi...@apache.org>.
henry3260 closed pull request #59424: Remove Legacy Query Object Usage from test_dag_bundle_manager.py
URL: https://github.com/apache/airflow/pull/59424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove Legacy Query Object Usage from test_dag_bundle_manager.py [airflow]
Posted by "henry3260 (via GitHub)" <gi...@apache.org>.
henry3260 commented on PR #59424:
URL: https://github.com/apache/airflow/pull/59424#issuecomment-3654113387
oops, I broke some test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove Legacy Query Object Usage from test_dag_bundle_manager.py [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on PR #59424:
URL: https://github.com/apache/airflow/pull/59424#issuecomment-3653549056
let's goo 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org