You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/04/28 18:28:06 UTC

[GitHub] [arrow-rs] tustvold opened a new pull request, #4157: Remove unnecessary RefCell from FileSource

tustvold opened a new pull request, #4157:
URL: https://github.com/apache/arrow-rs/pull/4157

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   This isn't actually necessary
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4157: Remove unnecessary RefCell from FileSource

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4157:
URL: https://github.com/apache/arrow-rs/pull/4157#discussion_r1180704302


##########
parquet/src/util/io.rs:
##########
@@ -89,9 +89,8 @@ impl<R: ParquetReader> FileSource<R> {
             // Branch using `>=` instead of the more correct `==`
             // to tell the compiler that the pos..cap slice is always valid.
             debug_assert!(self.buf_pos == self.buf_cap);
-            let mut reader = self.reader.borrow_mut();
-            reader.seek(SeekFrom::Start(self.start))?; // always seek to start before reading
-            self.buf_cap = reader.read(&mut self.buf)?;
+            self.reader.seek(SeekFrom::Start(self.start))?; // always seek to start before reading

Review Comment:
   This is technically still racy because cloned file descriptor share a seek position, but the refcell wasn't helping prevent this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4157: Remove unnecessary RefCell from FileSource

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4157:
URL: https://github.com/apache/arrow-rs/pull/4157#discussion_r1180704302


##########
parquet/src/util/io.rs:
##########
@@ -89,9 +89,8 @@ impl<R: ParquetReader> FileSource<R> {
             // Branch using `>=` instead of the more correct `==`
             // to tell the compiler that the pos..cap slice is always valid.
             debug_assert!(self.buf_pos == self.buf_cap);
-            let mut reader = self.reader.borrow_mut();
-            reader.seek(SeekFrom::Start(self.start))?; // always seek to start before reading
-            self.buf_cap = reader.read(&mut self.buf)?;
+            self.reader.seek(SeekFrom::Start(self.start))?; // always seek to start before reading

Review Comment:
   This is technically racy because cloned file descriptor share a seek position, but the refcell wasn't helping prevent this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold closed pull request #4157: Remove unnecessary RefCell from FileSource

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed pull request #4157: Remove unnecessary RefCell from FileSource
URL: https://github.com/apache/arrow-rs/pull/4157


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on pull request #4157: Remove unnecessary RefCell from FileSource

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4157:
URL: https://github.com/apache/arrow-rs/pull/4157#issuecomment-1528076638

   Closing in favour of #4156 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org