You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2023/01/03 19:19:25 UTC
[GitHub] [iceberg] RussellSpitzer opened a new issue, #6518: Improve Test Coverage of RowGroupFilter Code with Nans
RussellSpitzer opened a new issue, #6518:
URL: https://github.com/apache/iceberg/issues/6518
### Feature Request / Improvement
Currently bounds checking with NaN's in file metrics (for parquet) is essentially untested, I added a small set of tests in #6517 but we should probably have a full range of checks. The tests also need to be parameterized since for Parquet we can never correctly skip a file which contains NaN but this may not be the case for ORC.
Specifically we should have a set of tests in TestMetricsRowGroupFilter or TestMetricsRowGroupFilterTypes which covers double and float columns which contain NaN as well as non-nan values.
### Query engine
Other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] youngxinler commented on issue #6518: Improve Test Coverage of RowGroupFilter Code with Nans
Posted by GitBox <gi...@apache.org>.
youngxinler commented on issue #6518:
URL: https://github.com/apache/iceberg/issues/6518#issuecomment-1377031962
I have submitted PR. #6554 @RussellSpitzer can you help with the review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] lvyanquan commented on issue #6518: Improve Test Coverage of RowGroupFilter Code with Nans
Posted by GitBox <gi...@apache.org>.
lvyanquan commented on issue #6518:
URL: https://github.com/apache/iceberg/issues/6518#issuecomment-1370416508
Willing to do this if no one else asks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer closed issue #6518: Improve Test Coverage of RowGroupFilter Code with Nans
Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer closed issue #6518: Improve Test Coverage of RowGroupFilter Code with Nans
URL: https://github.com/apache/iceberg/issues/6518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org