[GitHub] [spark] William1104 commented on a change in pull request #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name and storage level

[GitBox <gi...@apache.org>]

William1104 commented on a change in pull request #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name and storage level
URL: https://github.com/apache/spark/pull/24221#discussion_r279992925
 
 

 ##########
 File path: docs/sql-migration-guide-upgrade.md
 ##########
 @@ -50,6 +50,8 @@ license: |
 
   - In Spark version 2.4 and earlier, JSON datasource and JSON functions like `from_json` convert a bad JSON record to a row with all `null`s in the PERMISSIVE mode when specified schema is `StructType`. Since Spark 3.0, the returned row can contain non-`null` fields if some of JSON column values were parsed and converted to desired types successfully.
 
+  - Refreshing a cached table would trigger a table uncache operation and then a table cache (lazily) operation. In Spark version 2.4 and earlier, the cache name ane cache storage level are not preserved before the uncache operation. Therefore, the cache name and cache storage level could be changed unexpectedly. Since Spark 3.0, cache name and cache storage level will be first preserved for cache recreation. It helps to maintain a consistent cache behavior upon table refreshing.
 
 Review comment:
   Hi @gatorsmile , thanks for confirming this. Btw, would you also mind to review this PR again? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org