You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/05/31 07:14:17 UTC

[GitHub] [activemq-artemis] brusdev commented on a change in pull request #2687: ARTEMIS-2359 Upgrade to Guava 24.1

brusdev commented on a change in pull request #2687: ARTEMIS-2359 Upgrade to Guava 24.1
URL: https://github.com/apache/activemq-artemis/pull/2687#discussion_r289280193
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -800,6 +800,12 @@
             <scope>provided</scope>
             <!-- License: Apache 2.0 -->
          </dependency>
+         <dependency>
 
 Review comment:
   I see your point but airlift/airline is added as global dependency and Guava is used by artemis-cli (XmlDataExporterUtil), by integrations-tests (MethodCalledVerifier) by airlift/airline and by hawtio/web.
   Airlift/airline is added as global dependency, as artemis-cli dependency and as artemis-distribution dependency.
   Hawtio/web is added as artemis-console dependency.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services