You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by borisroman <gi...@git.apache.org> on 2015/09/25 17:50:01 UTC
[GitHub] cloudstack pull request: [4.6]CLOUDSTACK-8912: Fixed listGuestOsMa...
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/890
[4.6]CLOUDSTACK-8912: Fixed listGuestOsMapping doesn't list by id or ostypeid.
How to test:
1. Try to listGuestOsMapping by id -> should return the correct entry.
2. Try to listGuestOsMapping by ostypeid -> should return the correct entry.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-8912
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/890.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #890
----
commit c2d3df395690f8e2c87afd559146c3ef05933005
Author: Boris Schrijver <bo...@pcextreme.nl>
Date: 2015-09-25T15:42:24Z
Fixed listGuestOsMapping doesn't list by id or ostypeid.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6]CLOUDSTACK-8912: Fixed listGuestOsMa...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/890#issuecomment-149790401
I tested this api just now,
It works fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6]CLOUDSTACK-8912: Fixed listGuestOsMa...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/890#issuecomment-143590703
@borisroman Can you rebase against current master? Then we can run some tests. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6]CLOUDSTACK-8912: Fixed listGuestOsMa...
Posted by resmo <gi...@git.apache.org>.
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/890#issuecomment-143290823
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6]CLOUDSTACK-8912: Fixed listGuestOsMa...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/890#discussion_r42615493
--- Diff: api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java ---
@@ -44,10 +44,10 @@
/////////////////////////////////////////////////////
@Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType = GuestOsMappingResponse.class, required = false, description = "list mapping by its UUID")
- private Long id;
+ private String id;
--- End diff --
@bhaisaab Thanks for pointing out! Will look into it. @remibergsma Please hold on merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6]CLOUDSTACK-8912: Fixed listGuestOsMa...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/890
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6]CLOUDSTACK-8912: Fixed listGuestOsMa...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/890#issuecomment-149677795
@borisroman,
Is this PR intended to fix the ordering of the response of listGuestOsMappingCommand?
I did not see where you changed the ordering on the SC used. Looking at the changed files list, I just see you changing types from Long to String.
I noticed that the order by is done in ascending order, using the field “hypervisorType”, is “hypervisorType” that same as “ostypeid”? Moreover, I could not find a field called “ostypeid”.
Interesting that the filtering and the order by was already there, this PR seems to be related to something else.Is it really a problem to let those field as they are (Long types)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6]CLOUDSTACK-8912: Fixed listGuestOsMa...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/890#discussion_r41697298
--- Diff: api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java ---
@@ -44,10 +44,10 @@
/////////////////////////////////////////////////////
@Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType = GuestOsMappingResponse.class, required = false, description = "list mapping by its UUID")
- private Long id;
+ private String id;
--- End diff --
This can cause issues here, during Cmd object creation arguments values of keys ID and OS_TYPE_ID will be converted to a Long as the parameter type defined here is CommandType.UUID.
This is where this happens: https://github.com/apache/cloudstack/blob/master/server/src/com/cloud/api/dispatch/ParamProcessWorker.java#L318
If you really want Strings here, please change the @Parameter annotation type to CommandType.STRING etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6]CLOUDSTACK-8912: Fixed listGuestOsMa...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/890#issuecomment-143689040
Thanks @borisroman I'll run soms tests today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6]CLOUDSTACK-8912: Fixed listGuestOsMa...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/890#issuecomment-143591008
@remibergsma Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6]CLOUDSTACK-8912: Fixed listGuestOsMa...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/890#issuecomment-149691403
why not add 'uuid' column in guest_os_type table?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---