[GitHub] [ozone] kerneltime commented on a diff in pull request #5118: HDDS-9081. Handling Netty back pressure when streaming containers for replication.

["kerneltime (via GitHub)" <gi...@apache.org>]

kerneltime commented on code in PR #5118:
URL: https://github.com/apache/ozone/pull/5118#discussion_r1275600084


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/GrpcContainerUploader.java:
##########
@@ -60,8 +61,9 @@ public OutputStream startUpload(long containerId, DatanodeDetails target,
       StreamObserver<SendContainerRequest> requestStream = client.upload(
           new SendContainerResponseStreamObserver(containerId, target,
               callback));
-      return new SendContainerOutputStream(requestStream, containerId,
-          GrpcReplicationService.BUFFER_SIZE, compression) {
+      return new SendContainerOutputStream(
+          (CallStreamObserver<SendContainerRequest>) requestStream,

Review Comment:
   Why not change ```private static class SendContainerResponseStreamObserver
         implements StreamObserver<SendContainerResponse> {``` to be `CallStreamObserver` 
   The casting seems odd.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org