[GitHub] [netbeans] junichi11 commented on a change in pull request #1771: [NETBEANS-3428] FlatLaf: UI delegates for editor and view tabs in main window

[GitBox <gi...@apache.org>]

junichi11 commented on a change in pull request #1771: [NETBEANS-3428] FlatLaf: UI delegates for editor and view tabs in main window
URL: https://github.com/apache/netbeans/pull/1771#discussion_r356819270
 
 

 ##########
 File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatLFCustoms.java
 ##########
 @@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.netbeans.swing.laf.flatlaf;
+
+import com.formdev.flatlaf.util.UIScale;
+import javax.swing.UIManager;
+import org.netbeans.swing.plaf.LFCustoms;
+
+/**
+ * LFCustoms for FlatLaf based LAFs (light, dark, etc).
+ * <p>
+ * Do not add colors here.
+ * Instead put colors into {@code FlatLightLaf.properties} or {@code FlatDarkLaf.properties}.
+ * <p>
+ * Public only to be accessible by ProxyLazyValue, please don't abuse.
+ */
+public class FlatLFCustoms extends LFCustoms {
+
+    @Override
+    public Object[] createApplicationSpecificKeysAndValues() {
+        return new Object[] {
+            EDITOR_TAB_DISPLAYER_UI, "org.netbeans.swing.laf.flatlaf.ui.FlatEditorTabDisplayerUI",
+            VIEW_TAB_DISPLAYER_UI, "org.netbeans.swing.laf.flatlaf.ui.FlatViewTabDisplayerUI",
+
+            EDITOR_TAB_CONTENT_BORDER, DPISafeBorder.matte(0, 1, 1, 1, UIManager.getColor("TabbedContainer.editor.contentBorderColor")),
+            VIEW_TAB_CONTENT_BORDER, DPISafeBorder.matte(0, 1, 1, 1, UIManager.getColor("TabbedContainer.view.contentBorderColor")),
 
 Review comment:
   Should add `// NOI18N`s

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists