[GitHub] [flink] twalthr commented on a change in pull request #9752: [FLINK-14179]Correct description of 'SHOW FUNCTIONS'

[GitBox <gi...@apache.org>]

twalthr commented on a change in pull request #9752: [FLINK-14179]Correct description of 'SHOW FUNCTIONS'
URL: https://github.com/apache/flink/pull/9752#discussion_r329563556
 
 

 ##########
 File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliStrings.java
 ##########
 @@ -52,7 +52,7 @@ private CliStrings() {
 		.append(formatCommand(SqlCommand.RESET, "Resets all session configuration properties."))
 		.append(formatCommand(SqlCommand.SELECT, "Executes a SQL SELECT query on the Flink cluster."))
 		.append(formatCommand(SqlCommand.SET, "Sets a session configuration property. Syntax: 'SET <key>=<value>;'. Use 'SET;' for listing all properties."))
-		.append(formatCommand(SqlCommand.SHOW_FUNCTIONS, "Shows all registered user-defined functions."))
+		.append(formatCommand(SqlCommand.SHOW_FUNCTIONS, "Shows all system-defined and registered user-defined functions."))
 
 Review comment:
   @wuchong fyi: actually we just had a discussion on the ML around temporary functions where we decided to call the built-in functions "system" functions. Like `CREATE TEMPORARY SYSTEM FUNCTION` if users want to override a built-in function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services