You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "ilariapet (via GitHub)" <gi...@apache.org> on 2025/10/17 14:04:47 UTC

[PR] SOLR-17927: Fix naming in vector search support [solr]

ilariapet opened a new pull request, #3789:
URL: https://github.com/apache/solr/pull/3789

   https://issues.apache.org/jira/browse/SOLR-17927
   
   # Description
   
   - Renamed neural search to vector search
   - Renamed maxConn and beamWidth to m and efConstruction
   - Renamed llm module to language-models
   
   _I avoided adding comments with references to Lucene, since we plan to change the names there as well._
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-17927: Fix naming in vector search support [solr]

Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #3789:
URL: https://github.com/apache/solr/pull/3789#issuecomment-3634680859

   Looks like it was approved by Alessandro October 22nd.  Then there was a minor fix and CHANGES.txt and then nothing for weeks.  At present, there's lots of merge conflicts.  Just at-mention me if I can be helpful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-17927: Fix naming in vector search support [solr]

Posted by "alessandrobenedetti (via GitHub)" <gi...@apache.org>.
alessandrobenedetti commented on code in PR #3789:
URL: https://github.com/apache/solr/pull/3789#discussion_r2450953510


##########
solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:
##########
@@ -86,13 +86,13 @@ public class DenseVectorField extends FloatPointField {
    * This parameter is coupled with the hnsw algorithm. Controls how many of the nearest neighbor
    * candidates are connected to the new node. See {@link HnswGraph} for more details.
    */
-  private int hnswMaxConn;
+  private int m;

Review Comment:
   m -> hnswM



##########
solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:
##########
@@ -86,13 +86,13 @@ public class DenseVectorField extends FloatPointField {
    * This parameter is coupled with the hnsw algorithm. Controls how many of the nearest neighbor
    * candidates are connected to the new node. See {@link HnswGraph} for more details.
    */
-  private int hnswMaxConn;
+  private int m;
 
   /**
    * This parameter is coupled with the hnsw algorithm. The number of candidate neighbors to track
    * while searching the graph for each newly inserted node. See {@link HnswGraph} for details.
    */
-  private int hnswBeamWidth;
+  private int efConstruction;

Review Comment:
   efConstruction -> hnswEfConstruction



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-17927: Fix naming in vector search support [solr]

Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #3789:
URL: https://github.com/apache/solr/pull/3789#issuecomment-3634693769

   This appears to be superseded / continued in #3830.  So lets close this, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-17927: Fix naming in vector search support [solr]

Posted by "cpoerschke (via GitHub)" <gi...@apache.org>.
cpoerschke commented on code in PR #3789:
URL: https://github.com/apache/solr/pull/3789#discussion_r2455205016


##########
solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc:
##########
@@ -228,3 +228,9 @@ Due to Lucene 10 changes (https://github.com/apache/lucene/pull/12875), `PathHie
   </analyzer>
 </fieldType>
 ----
+
+=== Renaming in Vector Search
+Attention:
+
+* The `llm` module has been renamed to `language-models`.
+* The HNSW parameters `hnswMaxConnections` and `hnswBeamWidth` have been renamed to `hnswM` and `hnswEfConstruction`, respectively, so they must be updated accordingly in the schema.xml file.

Review Comment:
   Curiosity only, I wonder if unused attributes are permitted in the schema e.g. might one go
   
   * from `hnswMaxConnections="10" hnswBeamWidth="40"` on Solr9
   * to `hnswMaxConnections="10" hnswBeamWidth="40" hnswM="10" hnswEfConstruction="40"` on Solr9
   * to `hnswMaxConnections="10" hnswBeamWidth="40" hnswM="10" hnswEfConstruction="40"` on Solr10
   * to `hnswM="10" hnswEfConstruction="40"` on Solr10
   
   conceptually?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-17927: Fix naming in vector search support [solr]

Posted by "ilariapet (via GitHub)" <gi...@apache.org>.
ilariapet closed pull request #3789: SOLR-17927: Fix naming in vector search support
URL: https://github.com/apache/solr/pull/3789


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org