You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/08 16:54:53 UTC
[GitHub] [incubator-nuttx] patacongo commented on issue #120:
tools/nxstyle.c: FALSE alarms on right hand aligned comments.
patacongo commented on issue #120: tools/nxstyle.c: FALSE alarms on right hand aligned comments.
URL: https://github.com/apache/incubator-nuttx/issues/120#issuecomment-596226398
I think that the problem is an ordering one in nxstyle.c:
- prevbrhcmt is true if the previous line is a right hand comment (brhcomment)
- It is set at line 661 if the last line was a right hand comment
- The error occurs because prevbrhcmt is not set at line 718 or
- Line 963 and 1395: right hand comment should propagate to a single line comment if single line comment was preceded by a right hand comment with no blank line.
I think that the error occurs because the test of prevbrhcmt at line 718 occurs BEFORE it is set the the current line at lines 963 or 1395
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services