You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Joris Van den Bossche (Jira)" <ji...@apache.org> on 2020/06/03 12:21:00 UTC
[jira] [Commented] (ARROW-9022) [C++][Compute] Make Add function
safe for numeric limits
[ https://issues.apache.org/jira/browse/ARROW-9022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124909#comment-17124909 ]
Joris Van den Bossche commented on ARROW-9022:
----------------------------------------------
For reference (not that this is necessarily an argument), numpy preserves the data types in addition (so int8 + int8 -> int8)
> [C++][Compute] Make Add function safe for numeric limits
> --------------------------------------------------------
>
> Key: ARROW-9022
> URL: https://issues.apache.org/jira/browse/ARROW-9022
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Krisztian Szucs
> Assignee: Krisztian Szucs
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.0.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently the output type of the Add function is identical with the argument types which makes it unsafe to add numeric limit values, so instead of using {{(int8, int8) -> int8}} signature we should use {{((int8, int8) -> int16}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)