[GitHub] rdblue commented on a change in pull request #25: Add the encryption metadata field to the DataFile schema

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #25: Add the encryption metadata field to the DataFile schema
URL: https://github.com/apache/incubator-iceberg/pull/25#discussion_r239649809
 
 

 ##########
 File path: api/src/main/java/com/netflix/iceberg/encryption/EncryptionTypes.java
 ##########
 @@ -0,0 +1,50 @@
+package com.netflix.iceberg.encryption;
+
+import com.netflix.iceberg.types.Types;
+
+import java.nio.ByteBuffer;
+
+public class EncryptionTypes {
 
 Review comment:
   This is quite a bit more complicated than what I envisioned. I assumed that this would be a single binary field, `key_ref`.
   
   Thinking about this more, I can see how we will need more than a field in DataFile. That has to be passed into the FileIO for your use case, and maybe passed to file format implementations for using things like Parquet encryption. But I do want to make sure that what we add is minimal.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services