You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/09/05 02:58:51 UTC
[GitHub] [trafficserver] bneradt opened a new pull request #8316: Remove incompatible changes for 9.2.0
bneradt opened a new pull request #8316:
URL: https://github.com/apache/trafficserver/pull/8316
We are preparing to branch 9.2.0 from master. In order to do this we need to remove all the incompatible changes currently in master. Our plan is this:
* Remove the incompatible changes from master using this PR. This PR contains all of the commits in the PRs currently marked with the "Incompatible" label reverted.
* Merge this PR via a squash merge (as usual) into master.
* Branch 9.2.0 from the point of this commit. It will not have these changes which are being reverted.
* Revert this single squashed commit on master so it has them again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich edited a comment on pull request #8316: Remove incompatible changes for 9.2.0
Posted by GitBox <gi...@apache.org>.
shinrich edited a comment on pull request #8316:
URL: https://github.com/apache/trafficserver/pull/8316#issuecomment-914483948
For the abort_threshold PR, part of that did go into 9.x 0bc810f0c2991e97a8ea4ff94deb6f248be694fd). The additional PR on master was just removing the enums, but it looks like this revert commit is adding back the documentation.
Oh, I see you have them both on the revert list. Since the first one has landed on 9.x, I think you only want to revert the commit that changes the enums
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8316: Remove incompatible changes for 9.2.0
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8316:
URL: https://github.com/apache/trafficserver/pull/8316#issuecomment-915592637
> @bneradt Can you add a comment here, listing all the PR #'s one by one, so we have a nice, clickable list of links of the PRs that are reverted ?
Sure thing:
1. https://github.com/apache/trafficserver/pull/8077
2. https://github.com/apache/trafficserver/pull/8066
3. https://github.com/apache/trafficserver/pull/7901
4. https://github.com/apache/trafficserver/pull/7693
5. https://github.com/apache/trafficserver/pull/7587
6. https://github.com/apache/trafficserver/pull/7547
7. https://github.com/apache/trafficserver/pull/7756
8. https://github.com/apache/trafficserver/pull/7335
9. https://github.com/apache/trafficserver/pull/7302
10. https://github.com/apache/trafficserver/pull/6602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8316: Remove incompatible changes for 9.2.0
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8316:
URL: https://github.com/apache/trafficserver/pull/8316#issuecomment-915499716
@bneradt Can you add a comment here, listing all the PR #'s one by one, so we have a nice, clickable list of links of the PRs that are reverted ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8316: Remove incompatible changes for 9.2.0
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8316:
URL: https://github.com/apache/trafficserver/pull/8316#issuecomment-915468313
> I'm fine with the plan, but I wonder why we want to revert incompatible changes on master first. I guess we can revert incompatible changes only on 9.2.x after branching 9.2.x. Commit history wise there would be no difference on 9.2.x branch. It would be just that there's no incompatible changes at the branching point. Although it sounds ideal, it implies that we have to redo whole this process if we find another incompatible change later.
Thanks for the thoughts. We shouldn't have to redo the whole process. If we find other incompatible changes after branching 9.2.x, we can just revert those on the 9.2.x branch. Master won't need any commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8316: Remove incompatible changes for 9.2.0
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8316:
URL: https://github.com/apache/trafficserver/pull/8316#issuecomment-916257015
I've changed Milestone and Project for all these PRs to "10-Dev".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8316: Remove incompatible changes for 9.2.0
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8316:
URL: https://github.com/apache/trafficserver/pull/8316#issuecomment-914524981
> Aside from the abort_threshold commits, the rest of the changes that I'm familiar with looked fine.
Thanks Susan! I'll put the other commit in and only leave the one that reverts the enums.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #8316: Remove incompatible changes for 9.2.0
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #8316:
URL: https://github.com/apache/trafficserver/pull/8316#issuecomment-914826322
I'm fine with the plan, but I wonder why we want to revert incompatible changes on master first. I guess we can revert incompatible changes only on 9.2.x after branching 9.2.x. Commit history wise there would be no difference on 9.2.x branch. It would be just that there's no incompatible changes at the branching point. Although it sounds ideal, it implies that we have to redo whole this process if we find another incompatible change later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #8316: Remove incompatible changes for 9.2.0
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #8316:
URL: https://github.com/apache/trafficserver/pull/8316#issuecomment-914483948
For the abort_threshold PR, part of that did go into 9.x 0bc810f0c2991e97a8ea4ff94deb6f248be694fd). The additional PR on master was just removing the enums, but it looks like this revert commit is adding back the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8316: Remove incompatible changes for 9.2.0
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8316:
URL: https://github.com/apache/trafficserver/pull/8316#issuecomment-915498493
Yeh, the reason for these steps was to having to redo these types of revert every time we make a branch off master. Maybe 9.2.x will be the last 9 branch, but if we do a 9.3.x and 9.4.x, it'll be nice to have "master" in a shape that's 100% 9.x compatible, and the 10-Dev branch with all the incompatible (and bigger) changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt merged pull request #8316: Remove incompatible changes for 9.2.0
Posted by GitBox <gi...@apache.org>.
bneradt merged pull request #8316:
URL: https://github.com/apache/trafficserver/pull/8316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #8316: Remove incompatible changes for 9.2.0
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #8316:
URL: https://github.com/apache/trafficserver/pull/8316#issuecomment-914486854
Aside from the abort_threshold commits, the rest of the changes that I'm familiar with looked fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org