You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "visortelle (via GitHub)" <gi...@apache.org> on 2023/12/23 18:51:31 UTC
[PR] [improve][misc] List Pulsar at the https://projects.apache.org [pulsar]
visortelle opened a new pull request, #21796:
URL: https://github.com/apache/pulsar/pull/21796
To be properly listed on the projects.apache.org, the project must have a DOAP file. More info: https://projects.apache.org/create.html
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
-->
<!-- Either this PR fixes an issue, -->
Fixes #xyz
<!-- or this PR is one task of an issue -->
Main Issue: #xyz
<!-- If the PR belongs to a PIP, please add the PIP link here -->
PIP: #xyz
<!-- Details of when a PIP is required and how the PIP process work, please see: https://github.com/apache/pulsar/blob/master/pip/README.md -->
### Motivation
The project has an entry here:
https://projects.apache.org/projects.html?name
but hasn't here: https://projects.apache.org/projects.html?language
and here: https://projects.apache.org/projects.html?category
@lhotari explained to me how to fix that here: https://lists.apache.org/thread/1q90j40vv6fb729fwlmc9npd6y2ws529
<!-- Explain here the context, and why you're making that change. What is the problem you're trying to solve. -->
### Modifications
<!-- Describe the modifications you've done. -->
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][misc] List Pulsar at the https://projects.apache.org [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #21796:
URL: https://github.com/apache/pulsar/pull/21796#issuecomment-1869574537
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21796?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`32f3577`)](https://app.codecov.io/gh/apache/pulsar/commit/32f3577a735581096d85aa961d7df45b9ae9b6f9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 73.61% compared to head [(`e50d547`)](https://app.codecov.io/gh/apache/pulsar/pull/21796?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 73.61%.
> Report is 4 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/pulsar/pull/21796?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #21796 +/- ##
============================================
- Coverage 73.61% 73.61% -0.01%
+ Complexity 32885 32259 -626
============================================
Files 1898 1858 -40
Lines 140668 138021 -2647
Branches 15492 15111 -381
============================================
- Hits 103559 101608 -1951
+ Misses 29080 28561 -519
+ Partials 8029 7852 -177
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/21796/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/21796/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.18% <ø> (-0.13%)` | :arrow_down: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/21796/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.73% <ø> (-1.28%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/21796/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.88% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 144 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/21796/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][misc] List Pulsar at the https://projects.apache.org [pulsar]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on PR #21796:
URL: https://github.com/apache/pulsar/pull/21796#issuecomment-1869480200
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][misc] List Pulsar at the https://projects.apache.org [pulsar]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #21796:
URL: https://github.com/apache/pulsar/pull/21796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][misc] List Pulsar at the https://projects.apache.org [pulsar]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on PR #21796:
URL: https://github.com/apache/pulsar/pull/21796#issuecomment-1869083740
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][misc] List Pulsar at the https://projects.apache.org [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #21796:
URL: https://github.com/apache/pulsar/pull/21796#issuecomment-1869718338
I have registered the url to https://svn.apache.org/repos/asf/comdev/projects.apache.org/trunk/data/projects.xml
with this svn commit https://svn.apache.org/viewvc?view=revision&revision=1914938 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][misc] List Pulsar at the https://projects.apache.org [pulsar]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #21796:
URL: https://github.com/apache/pulsar/pull/21796#issuecomment-1869481345
./ci/run_ci.sh format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][misc] List Pulsar at the https://projects.apache.org [pulsar]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on PR #21796:
URL: https://github.com/apache/pulsar/pull/21796#issuecomment-1869488780
> We may even skip running test for this file in .github/changes-filter.yaml
Probably, but it looks like a micro-optimization to me.
Unlikely this file will be changed frequently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][misc] List Pulsar at the https://projects.apache.org [pulsar]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #21796:
URL: https://github.com/apache/pulsar/pull/21796#issuecomment-1869489410
Yeah .. I just don't want to run test for this PR, lol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][misc] List Pulsar at the https://projects.apache.org [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #21796:
URL: https://github.com/apache/pulsar/pull/21796#discussion_r1436436144
##########
doap_Pulsar.rdf:
##########
@@ -0,0 +1,47 @@
+<?xml version="1.0"?>
+<?xml-stylesheet type="text/xsl"?>
+<rdf:RDF xml:lang="en"
+ xmlns="http://usefulinc.com/ns/doap#"
+ xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
+ xmlns:asfext="http://projects.apache.org/ns/asfext#"
+ xmlns:foaf="http://xmlns.com/foaf/0.1/">
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ https://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+ <Project rdf:about="https://pulsar.apache.org/">
+ <created>2023-12-23</created>
Review Comment:
I think this should be the project incubation date, that's `2018-09-19` for Pulsar
```suggestion
<created>2018-09-19</created>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org