You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "zhanglistar (via GitHub)" <gi...@apache.org> on 2026/01/22 12:10:51 UTC
[PR] [GLUTEN-11451][CH] Fix CH BNLJ left outer build side validation [incubator-gluten]
zhanglistar opened a new pull request, #11466:
URL: https://github.com/apache/incubator-gluten/pull/11466
## What changes are proposed in this pull request?
- Re-enable base validation for CH BroadcastNestedLoopJoin to reject invalid build sides (e.g., LeftOuter + BuildLeft).
- Add a regression test for left join with an existing but empty partition on the build side.
Fix [#11451](https://github.com/apache/incubator-gluten/issues/11451).
## Why is this change needed?
Gluten CH was accepting LeftOuter + BuildLeft in BNLJ, which violates Spark join semantics. When the right side is empty, the streamed side becomes empty and drops left rows, producing incorrect results compared to vanilla Spark.
## How was this patch tested?
- Added unit test in `GlutenClickHouseJoinSuite`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11451][CH] Fix CH BNLJ left outer build side validation [incubator-gluten]
Posted by "lgbo-ustc (via GitHub)" <gi...@apache.org>.
lgbo-ustc commented on code in PR #11466:
URL: https://github.com/apache/incubator-gluten/pull/11466#discussion_r2726138688
##########
backends-clickhouse/src/main/scala/org/apache/gluten/execution/CHBroadcastNestedLoopJoinExecTransformer.scala:
##########
@@ -111,15 +111,24 @@ case class CHBroadcastNestedLoopJoinExecTransformer(
}
override def validateJoinTypeAndBuildSide(): ValidationResult = {
+ (joinType, buildSide) match {
Review Comment:
Dose it fallback on this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11451][CH] Fix CH BNLJ left outer build side validation [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11466:
URL: https://github.com/apache/incubator-gluten/pull/11466#issuecomment-3798467398
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11451][CH] Fix CH BNLJ left outer build side validation [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11466:
URL: https://github.com/apache/incubator-gluten/pull/11466#issuecomment-3788819711
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11451][CH] Fix CH BNLJ left outer build side validation [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11466:
URL: https://github.com/apache/incubator-gluten/pull/11466#issuecomment-3798358917
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11451][CH] Fix CH BNLJ left outer build side validation [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11466:
URL: https://github.com/apache/incubator-gluten/pull/11466#issuecomment-3789078943
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11451][CH] Fix CH BNLJ left outer build side validation [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11466:
URL: https://github.com/apache/incubator-gluten/pull/11466#issuecomment-3798465684
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11451][CH] Fix CH BNLJ left outer build side validation [incubator-gluten]
Posted by "zhanglistar (via GitHub)" <gi...@apache.org>.
zhanglistar commented on code in PR #11466:
URL: https://github.com/apache/incubator-gluten/pull/11466#discussion_r2726693008
##########
backends-clickhouse/src/main/scala/org/apache/gluten/execution/CHBroadcastNestedLoopJoinExecTransformer.scala:
##########
@@ -111,15 +111,24 @@ case class CHBroadcastNestedLoopJoinExecTransformer(
}
override def validateJoinTypeAndBuildSide(): ValidationResult = {
+ (joinType, buildSide) match {
Review Comment:
fallback if empty, changed.
##########
backends-clickhouse/src/main/scala/org/apache/gluten/execution/CHBroadcastNestedLoopJoinExecTransformer.scala:
##########
@@ -111,15 +111,24 @@ case class CHBroadcastNestedLoopJoinExecTransformer(
}
override def validateJoinTypeAndBuildSide(): ValidationResult = {
+ (joinType, buildSide) match {
Review Comment:
fallback if empty, changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11451][CH] Fix CH BNLJ left outer build side validation [incubator-gluten]
Posted by "lgbo-ustc (via GitHub)" <gi...@apache.org>.
lgbo-ustc commented on code in PR #11466:
URL: https://github.com/apache/incubator-gluten/pull/11466#discussion_r2726138688
##########
backends-clickhouse/src/main/scala/org/apache/gluten/execution/CHBroadcastNestedLoopJoinExecTransformer.scala:
##########
@@ -111,15 +111,24 @@ case class CHBroadcastNestedLoopJoinExecTransformer(
}
override def validateJoinTypeAndBuildSide(): ValidationResult = {
+ (joinType, buildSide) match {
Review Comment:
Dose it fallback on this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11451][CH] Fix CH BNLJ left outer build side validation [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11466:
URL: https://github.com/apache/incubator-gluten/pull/11466#issuecomment-3784067355
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11451][CH] Fix CH BNLJ left outer build side validation [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11466:
URL: https://github.com/apache/incubator-gluten/pull/11466#issuecomment-3788813165
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11451][CH] Fix CH BNLJ left outer build side validation [incubator-gluten]
Posted by "zzcclp (via GitHub)" <gi...@apache.org>.
zzcclp merged PR #11466:
URL: https://github.com/apache/incubator-gluten/pull/11466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11451][CH] Fix CH BNLJ left outer build side validation [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11466:
URL: https://github.com/apache/incubator-gluten/pull/11466#issuecomment-3798462127
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11451][CH] Fix CH BNLJ left outer build side validation [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11466:
URL: https://github.com/apache/incubator-gluten/pull/11466#issuecomment-3788814749
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11451][CH] Fix CH BNLJ left outer build side validation [incubator-gluten]
Posted by "lgbo-ustc (via GitHub)" <gi...@apache.org>.
lgbo-ustc commented on code in PR #11466:
URL: https://github.com/apache/incubator-gluten/pull/11466#discussion_r2726139687
##########
backends-clickhouse/src/main/scala/org/apache/gluten/execution/CHBroadcastNestedLoopJoinExecTransformer.scala:
##########
@@ -111,15 +111,24 @@ case class CHBroadcastNestedLoopJoinExecTransformer(
}
override def validateJoinTypeAndBuildSide(): ValidationResult = {
+ (joinType, buildSide) match {
+ case (LeftOuter, BuildLeft) | (RightOuter, BuildRight) =>
+ return ValidationResult.failed(s"$joinType join is not supported with $buildSide")
+ case _ =>
+ }
+
joinType match {
- case _: InnerLike =>
+ case _: InnerLike | FullOuter | LeftOuter | RightOuter =>
Review Comment:
Is cross join not supported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11451][CH] Fix CH BNLJ left outer build side validation [incubator-gluten]
Posted by "zhanglistar (via GitHub)" <gi...@apache.org>.
zhanglistar commented on code in PR #11466:
URL: https://github.com/apache/incubator-gluten/pull/11466#discussion_r2726757724
##########
backends-clickhouse/src/main/scala/org/apache/gluten/execution/CHBroadcastNestedLoopJoinExecTransformer.scala:
##########
@@ -111,15 +111,24 @@ case class CHBroadcastNestedLoopJoinExecTransformer(
}
override def validateJoinTypeAndBuildSide(): ValidationResult = {
+ (joinType, buildSide) match {
+ case (LeftOuter, BuildLeft) | (RightOuter, BuildRight) =>
+ return ValidationResult.failed(s"$joinType join is not supported with $buildSide")
+ case _ =>
+ }
+
joinType match {
- case _: InnerLike =>
+ case _: InnerLike | FullOuter | LeftOuter | RightOuter =>
Review Comment:
Should not modify this, restored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org