You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/10/19 22:09:00 UTC
[jira] [Commented] (IMPALA-11673) Exclude spring-jcl from the classpath
[ https://issues.apache.org/jira/browse/IMPALA-11673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17620625#comment-17620625 ]
ASF subversion and git services commented on IMPALA-11673:
----------------------------------------------------------
Commit 0935c382e37644e193512494ac7a906b5d4e2e13 in impala's branch refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=0935c382e ]
IMPALA-11673: Exclude spring-jcl from the Java build
spring-core has a dependency on spring-jcl, which is
a jar that implements the same classes as commons-logging.
Having both on the classpath can lead to conflicts and
errors. Since commons-logging is already on the classpath
via other dependencies, this excludes spring-jcl and adds
it to the list of banned dependencies.
Testing:
- Ran core job
- Verified spring-jcl is not present
Change-Id: Ifeb741788662ec1b46303154b40109a4eef67005
Reviewed-on: http://gerrit.cloudera.org:8080/19154
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Exclude spring-jcl from the classpath
> -------------------------------------
>
> Key: IMPALA-11673
> URL: https://issues.apache.org/jira/browse/IMPALA-11673
> Project: IMPALA
> Issue Type: Task
> Components: Frontend
> Affects Versions: Impala 4.2.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Critical
>
> The dependency on spring-core brings in spring-jcl, which is intended as a replacement for the commons-logging framework. spring-jcl implements classes that overlap with commons-logging (which Impala also has on its classpath).
> https://github.com/spring-projects/spring-framework/issues/20611#issuecomment-453462024
> It doesn't seem useful to have spring-jcl around, so let's exclude it to avoid this overlap.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org