You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2009/05/08 12:15:54 UTC

svn commit: r772914 - /ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp

Author: jleroux
Date: Fri May  8 10:15:54 2009
New Revision: 772914

URL: http://svn.apache.org/viewvc?rev=772914&view=rev
Log:
A patch from BJ Freeman "Explaination of where the data is in ModelInduceFromDb.jsp" (https://issues.apache.org/jira/browse/OFBIZ-2432) - OFBIZ-2432

Modified:
    ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp

Modified: ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp?rev=772914&r1=772913&r2=772914&view=diff
==============================================================================
--- ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp (original)
+++ ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp Fri May  8 10:15:54 2009
@@ -30,7 +30,10 @@
     <input type=SUBMIT value='Induce!'>
 </form>
 It's the datasource name. It doesn't need to be associated with a
- delegator, just defined in entityengine.xml.
+ delegator, just defined in entityengine.xml.<br>
+   <b> Use the browser to view the source and see the entities that were created.</b>
+
+
 
 
 
@@ -54,7 +57,7 @@
       if(newEntList != null) {
         String title = "Entity of an Apache Open For Business Project (Apache OFBiz) Component";
         String description = "None";
-        String copyright = "Copyright 2001-2008 The Apache Software Foundation";
+        String copyright = "Copyright 2001-2009 The Apache Software Foundation";
         String author = "None";
         String version = "1.0";
 %><?xml version="1.0" encoding="UTF-8"?>
@@ -143,3 +146,4 @@
   %>ERROR: You do not have permission to use this page (ENTITY_MAINT needed)<%
 }
 %>
+



Re: svn commit: r772914 - /ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp

Posted by Ashish Vijaywargiya <as...@hotwaxmedia.com>.
+1

IMO all the three can be back ported to RB9.04, Jacques.
For now atleast you can apply r772941.

Before committing the remaining two we should wait for at least three 
feedback IMO.

--
Ashish

Jacques Le Roux wrote:
> Following : http://markmail.org/message/znytl2y4inpmxbdo, I have 
> removed all automatic copyright updates in OFBiz at r772941  and
> added one missing in r772936 at r772939
>
> I think that we should backport these 3 commits to R9.04. At least 
> r772941, since it's not legal, but I'd far prefer the 3 in R9.04!
>
> Jacques
>
> From: "Jacques Le Roux" <ja...@les7arts.com>
>> Thanks for reminder Ashish,
>>
>> Done in trunk at revision: 772936
>>
>> As I already commented when closing : I wonder now if we should not 
>> backport this to R9.04. It's obviously not a bug, but it can't hurt 
>> in any ways and especially it's weird to release without he copyright 
>> updated at the date of the release...
>>
>> Jacques
>>
>> From: "Ashish Vijaywargiya" <as...@hotwaxmedia.com>
>>> If its good to change the copyright details then my patch is also 
>>> ready to commit ;).
>>> As per David Goodenough's comment we should not change year upto 
>>> indefinite time.
>>>
>>> So please use my first patch where we have changed the value 
>>> explicitly from 2001-2008 to 2001-2009 :-)
>>> https://issues.apache.org/jira/browse/OFBIZ-2346
>>>
>>> -- 
>>> Ashish
>>>
>>> jleroux@apache.org wrote:
>>>> Author: jleroux
>>>> Date: Fri May  8 10:15:54 2009
>>>> New Revision: 772914
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=772914&view=rev
>>>> Log:
>>>> A patch from BJ Freeman "Explaination of where the data is in 
>>>> ModelInduceFromDb.jsp" 
>>>> (https://issues.apache.org/jira/browse/OFBIZ-2432) - OFBIZ-2432
>>>>
>>>> Modified:
>>>>     
>>>> ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp 
>>>>
>>>>
>>>> Modified: 
>>>> ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp 
>>>>
>>>> URL: 
>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp?rev=772914&r1=772913&r2=772914&view=diff 
>>>>
>>>> ============================================================================== 
>>>>
>>>> --- 
>>>> ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp 
>>>> (original)
>>>> +++ 
>>>> ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp 
>>>> Fri May  8 10:15:54 2009
>>>> @@ -30,7 +30,10 @@
>>>>      <input type=SUBMIT value='Induce!'>
>>>>  </form>
>>>>  It's the datasource name. It doesn't need to be associated with a
>>>> - delegator, just defined in entityengine.xml.
>>>> + delegator, just defined in entityengine.xml.<br>
>>>> +   <b> Use the browser to view the source and see the entities 
>>>> that were created.</b>
>>>> +
>>>> +
>>>>  @@ -54,7 +57,7 @@
>>>>        if(newEntList != null) {
>>>>          String title = "Entity of an Apache Open For Business 
>>>> Project (Apache OFBiz) Component";
>>>>          String description = "None";
>>>> -        String copyright = "Copyright 2001-2008 The Apache 
>>>> Software Foundation";
>>>> +        String copyright = "Copyright 2001-2009 The Apache 
>>>> Software Foundation";
>>>>          String author = "None";
>>>>          String version = "1.0";
>>>>  %><?xml version="1.0" encoding="UTF-8"?>
>>>> @@ -143,3 +146,4 @@
>>>>    %>ERROR: You do not have permission to use this page 
>>>> (ENTITY_MAINT needed)<%
>>>>  }
>>>>  %>
>>>> +
>>>>
>>>>
>>>>
>>>
>>
>>
>
>

Re: svn commit: r772914 - /ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp

Posted by Jacques Le Roux <ja...@les7arts.com>.
Following : http://markmail.org/message/znytl2y4inpmxbdo, I have removed all automatic copyright updates in OFBiz at r772941  and
added one missing in r772936 at r772939

I think that we should backport these 3 commits to R9.04. At least r772941, since it's not legal, but I'd far prefer the 3 in R9.04!

Jacques

From: "Jacques Le Roux" <ja...@les7arts.com>
> Thanks for reminder Ashish,
>
> Done in trunk at revision: 772936
>
> As I already commented when closing : I wonder now if we should not backport this to R9.04. It's obviously not a bug, but it can't 
> hurt in any ways and especially it's weird to release without he copyright updated at the date of the release...
>
> Jacques
>
> From: "Ashish Vijaywargiya" <as...@hotwaxmedia.com>
>> If its good to change the copyright details then my patch is also ready to commit ;).
>> As per David Goodenough's comment we should not change year upto indefinite time.
>>
>> So please use my first patch where we have changed the value explicitly from 2001-2008 to 2001-2009 :-)
>> https://issues.apache.org/jira/browse/OFBIZ-2346
>>
>> --
>> Ashish
>>
>> jleroux@apache.org wrote:
>>> Author: jleroux
>>> Date: Fri May  8 10:15:54 2009
>>> New Revision: 772914
>>>
>>> URL: http://svn.apache.org/viewvc?rev=772914&view=rev
>>> Log:
>>> A patch from BJ Freeman "Explaination of where the data is in ModelInduceFromDb.jsp" 
>>> (https://issues.apache.org/jira/browse/OFBIZ-2432) - OFBIZ-2432
>>>
>>> Modified:
>>>     ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp
>>>
>>> Modified: ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp
>>> URL: 
>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp?rev=772914&r1=772913&r2=772914&view=diff
>>> ==============================================================================
>>> --- ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp (original)
>>> +++ ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp Fri May  8 10:15:54 2009
>>> @@ -30,7 +30,10 @@
>>>      <input type=SUBMIT value='Induce!'>
>>>  </form>
>>>  It's the datasource name. It doesn't need to be associated with a
>>> - delegator, just defined in entityengine.xml.
>>> + delegator, just defined in entityengine.xml.<br>
>>> +   <b> Use the browser to view the source and see the entities that were created.</b>
>>> +
>>> +
>>>  @@ -54,7 +57,7 @@
>>>        if(newEntList != null) {
>>>          String title = "Entity of an Apache Open For Business Project (Apache OFBiz) Component";
>>>          String description = "None";
>>> -        String copyright = "Copyright 2001-2008 The Apache Software Foundation";
>>> +        String copyright = "Copyright 2001-2009 The Apache Software Foundation";
>>>          String author = "None";
>>>          String version = "1.0";
>>>  %><?xml version="1.0" encoding="UTF-8"?>
>>> @@ -143,3 +146,4 @@
>>>    %>ERROR: You do not have permission to use this page (ENTITY_MAINT needed)<%
>>>  }
>>>  %>
>>> +
>>>
>>>
>>>
>>
>
> 



Re: svn commit: r772914 - /ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp

Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks for reminder Ashish,

Done in trunk at revision: 772936

As I already commented when closing : I wonder now if we should not backport this to R9.04. It's obviously not a bug, but it can't 
hurt in any ways and especially it's weird to release without he copyright updated at the date of the release...

Jacques

From: "Ashish Vijaywargiya" <as...@hotwaxmedia.com>
> If its good to change the copyright details then my patch is also ready to commit ;).
> As per David Goodenough's comment we should not change year upto indefinite time.
>
> So please use my first patch where we have changed the value explicitly from 2001-2008 to 2001-2009 :-)
> https://issues.apache.org/jira/browse/OFBIZ-2346
>
> --
> Ashish
>
> jleroux@apache.org wrote:
>> Author: jleroux
>> Date: Fri May  8 10:15:54 2009
>> New Revision: 772914
>>
>> URL: http://svn.apache.org/viewvc?rev=772914&view=rev
>> Log:
>> A patch from BJ Freeman "Explaination of where the data is in ModelInduceFromDb.jsp" 
>> (https://issues.apache.org/jira/browse/OFBIZ-2432) - OFBIZ-2432
>>
>> Modified:
>>     ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp
>>
>> Modified: ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp
>> URL: 
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp?rev=772914&r1=772913&r2=772914&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp (original)
>> +++ ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp Fri May  8 10:15:54 2009
>> @@ -30,7 +30,10 @@
>>      <input type=SUBMIT value='Induce!'>
>>  </form>
>>  It's the datasource name. It doesn't need to be associated with a
>> - delegator, just defined in entityengine.xml.
>> + delegator, just defined in entityengine.xml.<br>
>> +   <b> Use the browser to view the source and see the entities that were created.</b>
>> +
>> +
>>  @@ -54,7 +57,7 @@
>>        if(newEntList != null) {
>>          String title = "Entity of an Apache Open For Business Project (Apache OFBiz) Component";
>>          String description = "None";
>> -        String copyright = "Copyright 2001-2008 The Apache Software Foundation";
>> +        String copyright = "Copyright 2001-2009 The Apache Software Foundation";
>>          String author = "None";
>>          String version = "1.0";
>>  %><?xml version="1.0" encoding="UTF-8"?>
>> @@ -143,3 +146,4 @@
>>    %>ERROR: You do not have permission to use this page (ENTITY_MAINT needed)<%
>>  }
>>  %>
>> +
>>
>>
>>
> 



Re: svn commit: r772914 - /ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp

Posted by Ashish Vijaywargiya <as...@hotwaxmedia.com>.
If its good to change the copyright details then my patch is also ready 
to commit ;).
As per David Goodenough's comment we should not change year upto 
indefinite time.

So please use my first patch where we have changed the value explicitly 
from 2001-2008 to 2001-2009 :-)
https://issues.apache.org/jira/browse/OFBIZ-2346

--
Ashish

jleroux@apache.org wrote:
> Author: jleroux
> Date: Fri May  8 10:15:54 2009
> New Revision: 772914
>
> URL: http://svn.apache.org/viewvc?rev=772914&view=rev
> Log:
> A patch from BJ Freeman "Explaination of where the data is in ModelInduceFromDb.jsp" (https://issues.apache.org/jira/browse/OFBIZ-2432) - OFBIZ-2432
>
> Modified:
>     ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp
>
> Modified: ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp?rev=772914&r1=772913&r2=772914&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp (original)
> +++ ofbiz/trunk/framework/webtools/webapp/webtools/entity/ModelInduceFromDb.jsp Fri May  8 10:15:54 2009
> @@ -30,7 +30,10 @@
>      <input type=SUBMIT value='Induce!'>
>  </form>
>  It's the datasource name. It doesn't need to be associated with a
> - delegator, just defined in entityengine.xml.
> + delegator, just defined in entityengine.xml.<br>
> +   <b> Use the browser to view the source and see the entities that were created.</b>
> +
> +
>  
>  
>  
> @@ -54,7 +57,7 @@
>        if(newEntList != null) {
>          String title = "Entity of an Apache Open For Business Project (Apache OFBiz) Component";
>          String description = "None";
> -        String copyright = "Copyright 2001-2008 The Apache Software Foundation";
> +        String copyright = "Copyright 2001-2009 The Apache Software Foundation";
>          String author = "None";
>          String version = "1.0";
>  %><?xml version="1.0" encoding="UTF-8"?>
> @@ -143,3 +146,4 @@
>    %>ERROR: You do not have permission to use this page (ENTITY_MAINT needed)<%
>  }
>  %>
> +
>
>
>