You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "Svecco (via GitHub)" <gi...@apache.org> on 2026/02/24 05:42:30 UTC
[PR] feat(ci): impl typos automatically checks [iggy]
Svecco opened a new pull request, #2803:
URL: https://github.com/apache/iggy/pull/2803
Referring #2802 , Consider implementing automated typo checking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): impl typos automatically checks [iggy]
Posted by "mmodzelewski (via GitHub)" <gi...@apache.org>.
mmodzelewski commented on PR #2803:
URL: https://github.com/apache/iggy/pull/2803#issuecomment-3957691115
@Svecco LGTM, thanks for the fixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): impl typos automatically checks [iggy]
Posted by "Svecco (via GitHub)" <gi...@apache.org>.
Svecco commented on PR #2803:
URL: https://github.com/apache/iggy/pull/2803#issuecomment-3955857289
Hi, corrections done, cc @hubcio @mmodzelewski
- `are set of -> are set to`
- including autogen files to exclude list, also did .gitignore
- rebase to the latest, as CodeCov warned(?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): impl typos automatically checks [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on code in PR #2803:
URL: https://github.com/apache/iggy/pull/2803#discussion_r2845642023
##########
core/configs/src/configs_impl/typed_env_provider.rs:
##########
@@ -502,10 +502,10 @@ mod tests {
.into_iter()
.collect();
- let suggestions = TypedEnvProvider::<TestConfig>::find_similar_vars("TEST_ENABELD", &known);
+ let suggestions = TypedEnvProvider::<TestConfig>::find_similar_vars("TEST_ENABLED", &known);
Review Comment:
this was deliberately mistake... check what is it testing (levenshtein distance)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): impl typos automatically checks [iggy]
Posted by "Svecco (via GitHub)" <gi...@apache.org>.
Svecco commented on code in PR #2803:
URL: https://github.com/apache/iggy/pull/2803#discussion_r2850299156
##########
examples/csharp/Iggy_SDK.Examples.sln.DotSettings:
##########
@@ -1,4 +1,4 @@
-<wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
Review Comment:
yup, you're right, I've corrected it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): impl typos automatically checks [iggy]
Posted by "mmodzelewski (via GitHub)" <gi...@apache.org>.
mmodzelewski commented on code in PR #2803:
URL: https://github.com/apache/iggy/pull/2803#discussion_r2849191280
##########
core/cli/src/args/user.rs:
##########
@@ -142,7 +142,7 @@ pub(crate) struct UserCreateArgs {
///
/// Stream permissions are defined by each stream separately. Setting permission for stream
/// allows to set each permission individually, by default, if no permission is provided
- /// (only stream ID is provided) all are set fo false. Stream permission format consists
+ /// (only stream ID is provided) all are set of false. Stream permission format consists
Review Comment:
this is a repeating issue, I think it should be changed to `to` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): impl typos automatically checks [iggy]
Posted by "mmodzelewski (via GitHub)" <gi...@apache.org>.
mmodzelewski commented on code in PR #2803:
URL: https://github.com/apache/iggy/pull/2803#discussion_r2849210681
##########
examples/csharp/Iggy_SDK.Examples.sln.DotSettings:
##########
@@ -1,4 +1,4 @@
-<wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
Review Comment:
This is a generated file, I wouldn't change that. If you google this, it actually looks that this is an existing/correct name.
##########
foreign/csharp/Iggy_SDK.sln.DotSettings:
##########
@@ -1,4 +1,4 @@
-<wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
Review Comment:
same as the file in `examples`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): impl typos automatically checks [iggy]
Posted by "mmodzelewski (via GitHub)" <gi...@apache.org>.
mmodzelewski merged PR #2803:
URL: https://github.com/apache/iggy/pull/2803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): impl typos automatically checks [iggy]
Posted by "Svecco (via GitHub)" <gi...@apache.org>.
Svecco commented on PR #2803:
URL: https://github.com/apache/iggy/pull/2803#issuecomment-3949427320
WIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): impl typos automatically checks [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2803:
URL: https://github.com/apache/iggy/pull/2803#issuecomment-3949262172
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/2803?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 64.11%. Comparing base ([`d897efb`](https://app.codecov.io/gh/apache/iggy/commit/d897efbab6f847c517a546f2ed1397ffef3860cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`329c382`](https://app.codecov.io/gh/apache/iggy/commit/329c3829557844453007dda48b46d5a0843b7e76?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2803 +/- ##
============================================
- Coverage 68.41% 64.11% -4.31%
Complexity 656 656
============================================
Files 852 852
Lines 68182 68176 -6
Branches 59643 59647 +4
============================================
- Hits 46648 43708 -2940
- Misses 19201 22340 +3139
+ Partials 2333 2128 -205
```
| [Flag](https://app.codecov.io/gh/apache/iggy/pull/2803/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [csharp](https://app.codecov.io/gh/apache/iggy/pull/2803/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `12.62% <ø> (-54.63%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/2803?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core/cli/src/args/message.rs](https://app.codecov.io/gh/apache/iggy/pull/2803?src=pr&el=tree&filepath=core%2Fcli%2Fsrc%2Fargs%2Fmessage.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jbGkvc3JjL2FyZ3MvbWVzc2FnZS5ycw==) | `65.85% <ø> (-0.28%)` | :arrow_down: |
| [core/common/src/commands/messages/send\_messages.rs](https://app.codecov.io/gh/apache/iggy/pull/2803?src=pr&el=tree&filepath=core%2Fcommon%2Fsrc%2Fcommands%2Fmessages%2Fsend_messages.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb21tb24vc3JjL2NvbW1hbmRzL21lc3NhZ2VzL3NlbmRfbWVzc2FnZXMucnM=) | `82.94% <ø> (+0.55%)` | :arrow_up: |
| [...ore/configs/src/configs\_impl/typed\_env\_provider.rs](https://app.codecov.io/gh/apache/iggy/pull/2803?src=pr&el=tree&filepath=core%2Fconfigs%2Fsrc%2Fconfigs_impl%2Ftyped_env_provider.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25maWdzL3NyYy9jb25maWdzX2ltcGwvdHlwZWRfZW52X3Byb3ZpZGVyLnJz) | `90.19% <ø> (-0.07%)` | :arrow_down: |
| [core/consensus/src/plane\_helpers.rs](https://app.codecov.io/gh/apache/iggy/pull/2803?src=pr&el=tree&filepath=core%2Fconsensus%2Fsrc%2Fplane_helpers.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25zZW5zdXMvc3JjL3BsYW5lX2hlbHBlcnMucnM=) | `20.56% <ø> (ø)` | |
| [.../binary/handlers/messages/send\_messages\_handler.rs](https://app.codecov.io/gh/apache/iggy/pull/2803?src=pr&el=tree&filepath=core%2Fserver%2Fsrc%2Fbinary%2Fhandlers%2Fmessages%2Fsend_messages_handler.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXIvc3JjL2JpbmFyeS9oYW5kbGVycy9tZXNzYWdlcy9zZW5kX21lc3NhZ2VzX2hhbmRsZXIucnM=) | `100.00% <ø> (ø)` | |
| [core/server/src/io/storage.rs](https://app.codecov.io/gh/apache/iggy/pull/2803?src=pr&el=tree&filepath=core%2Fserver%2Fsrc%2Fio%2Fstorage.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXIvc3JjL2lvL3N0b3JhZ2UucnM=) | `0.00% <ø> (ø)` | |
| [...Iggy\_SDK/Exceptions/InvalidBaseAddressException.cs](https://app.codecov.io/gh/apache/iggy/pull/2803?src=pr&el=tree&filepath=foreign%2Fcsharp%2FIggy_SDK%2FExceptions%2FInvalidBaseAddressException.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9jc2hhcnAvSWdneV9TREsvRXhjZXB0aW9ucy9JbnZhbGlkQmFzZUFkZHJlc3NFeGNlcHRpb24uY3M=) | `0.00% <ø> (ø)` | |
| [.../csharp/Iggy\_SDK/Extensions/IggyClientExtension.cs](https://app.codecov.io/gh/apache/iggy/pull/2803?src=pr&el=tree&filepath=foreign%2Fcsharp%2FIggy_SDK%2FExtensions%2FIggyClientExtension.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9jc2hhcnAvSWdneV9TREsvRXh0ZW5zaW9ucy9JZ2d5Q2xpZW50RXh0ZW5zaW9uLmNz) | `0.00% <ø> (ø)` | |
... and [82 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/2803/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): impl typos automatically checks [iggy]
Posted by "Svecco (via GitHub)" <gi...@apache.org>.
Svecco commented on code in PR #2803:
URL: https://github.com/apache/iggy/pull/2803#discussion_r2846488695
##########
core/configs/src/configs_impl/typed_env_provider.rs:
##########
@@ -502,10 +502,10 @@ mod tests {
.into_iter()
.collect();
- let suggestions = TypedEnvProvider::<TestConfig>::find_similar_vars("TEST_ENABELD", &known);
+ let suggestions = TypedEnvProvider::<TestConfig>::find_similar_vars("TEST_ENABLED", &known);
Review Comment:
Got it, I only glanced var or filename diff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org