You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by tn...@apache.org on 2013/01/21 12:29:59 UTC

svn commit: r1436283 - /commons/proper/collections/trunk/findbugs-exclude-filter.xml

Author: tn
Date: Mon Jan 21 11:29:58 2013
New Revision: 1436283

URL: http://svn.apache.org/viewvc?rev=1436283&view=rev
Log:
Add findbugs exclude filter for Flat3Map: switch fall-throughs and missing default case are intentional.

Modified:
    commons/proper/collections/trunk/findbugs-exclude-filter.xml

Modified: commons/proper/collections/trunk/findbugs-exclude-filter.xml
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/findbugs-exclude-filter.xml?rev=1436283&r1=1436282&r2=1436283&view=diff
==============================================================================
--- commons/proper/collections/trunk/findbugs-exclude-filter.xml (original)
+++ commons/proper/collections/trunk/findbugs-exclude-filter.xml Mon Jan 21 11:29:58 2013
@@ -30,4 +30,14 @@
     <Bug pattern="NP_BOOLEAN_RETURN_NULL" />
   </Match>
 
+  <!--  Flat3Map and its inner classes use intentional switch fall-through. The missing
+        default clause is safe and omitted for better readibility.                       -->
+  <Match>
+	<Class name="~org.apache.commons.collections.map.Flat3Map.*" />
+    <Or>
+	  <Bug pattern="SF_SWITCH_FALLTHROUGH" />
+	  <Bug pattern="SF_SWITCH_NO_DEFAULT" />
+    </Or>
+  </Match>
+
 </FindBugsFilter>