You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Mark Slee (JIRA)" <ji...@apache.org> on 2009/08/13 21:21:14 UTC
[jira] Created: (THRIFT-561) Add "register" to list of reserved
keywords
Add "register" to list of reserved keywords
-------------------------------------------
Key: THRIFT-561
URL: https://issues.apache.org/jira/browse/THRIFT-561
Project: Thrift
Issue Type: Bug
Components: Compiler (C++)
Affects Versions: 0.1, 0.2
Reporter: Mark Slee
Assignee: Mark Slee
Priority: Trivial
We should not allow "register" to be used as a service/method/variable name because it is reserved in C++.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-561) Add "register" to list of reserved
keywords
Posted by "Mark Slee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Slee resolved THRIFT-561.
------------------------------
Resolution: Fixed
Committed revision 803997.
> Add "register" to list of reserved keywords
> -------------------------------------------
>
> Key: THRIFT-561
> URL: https://issues.apache.org/jira/browse/THRIFT-561
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (C++)
> Affects Versions: 0.1, 0.2
> Reporter: Mark Slee
> Assignee: Mark Slee
> Priority: Trivial
>
> We should not allow "register" to be used as a service/method/variable name because it is reserved in C++.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-561) Add "register" to list of reserved
keywords
Posted by "Mark Slee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742933#action_12742933 ]
Mark Slee commented on THRIFT-561:
----------------------------------
Index: thriftl.ll
===================================================================
--- thriftl.ll (revision 803994)
+++ thriftl.ll (working copy)
@@ -180,6 +180,7 @@
"private" { thrift_reserved_keyword(yytext); }
"protected" { thrift_reserved_keyword(yytext); }
"raise" { thrift_reserved_keyword(yytext); }
+"register" { thrift_reserved_keyword(yytext); }
"return" { thrift_reserved_keyword(yytext); }
"sizeof" { thrift_reserved_keyword(yytext); }
"static" { thrift_reserved_keyword(yytext); }
> Add "register" to list of reserved keywords
> -------------------------------------------
>
> Key: THRIFT-561
> URL: https://issues.apache.org/jira/browse/THRIFT-561
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (C++)
> Affects Versions: 0.1, 0.2
> Reporter: Mark Slee
> Assignee: Mark Slee
> Priority: Trivial
>
> We should not allow "register" to be used as a service/method/variable name because it is reserved in C++.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.