[PR] Move optional JDBC DistSQL handlers to distribution profiles [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu opened a new pull request, #40154:
URL: https://github.com/apache/shardingsphere/pull/40154

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Move optional JDBC DistSQL handlers to distribution profiles [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu commented on PR #40154:
URL: https://github.com/apache/shardingsphere/pull/40154#issuecomment-6106549583

   ### Result
   
   **Review Result: Mergeable**
   
   The candidate satisfies the authorized SDK contract: ordinary consumers
   explicitly select the six optional features, while distribution profiles
   supply the corresponding handlers. The scope and dependency ownership
   are appropriate.
   
   ### Evidence
   
   - Reviewed the complete changes in jdbc/pom.xml and distribution/jdbc/pom.xml:
     removed six SDK production handlers, retained only the test-scoped
     sharding handler, and replaced 19 JDBC distribution core declarations
     with handlers. Proxy matches the baseline. No new dependencyManagement,
     exclusions, profiles, Java, or SPI changes. MySQL enhancements and
     necessary Pipeline dependencies are preserved.
   - All 20 combinations passed current-source effective POM, runtime
     dependency tree, and actual distribution archive checks. The multi-database
     combination without features contains none of the six handlers.
     An SDK-only consumer contains none of the six features; an explicit
     encryption consumer contains only encryption among those six.
   - All 1,252 SDK tests across 53 classes passed. All 24 distribution
     functional checks passed, covering actual Rule/SHOW execution,
     AES/MD5, MySQL provider loading, and JDBC DistSQL queries using
     Memory repository with an empty data-source map. Both SDK production
     SPI/kernel-parser checks passed. One temporary probe used the wrong
     parser API; it was corrected, with the failed attempt preserved.
   - Spotless checked both changed POMs and the restored Proxy POM,
     selecting one file in each module. Apache RAT passed.
     Checkstyle is not applicable because no Java files changed.
     The independent audit found no added defensive constructs.
   
   ### Coverage
   
   Standalone local-only review against the original task baseline
   c7d035967bfb. The final diff contains only the two POMs above;
   Proxy was independently confirmed byte-for-byte identical to the baseline.
   Dependency supply, contract impact, tests, and runtime checks were reviewed
   under the accepted SDK compatibility change. No unresolved review gaps
   remain within this scope. CI was not reviewed.
   
   Not verified: DataSource/Connection creation using the SDK production
   classpath alone; Oracle/ZooKeeper connections; Proxy protocols;
   backend routing and reads/writes; DistSQL updates; MySQL DAL merging;
   Pipeline, transaction, or federation execution; combinations outside
   the matrix. The full repository test suite was not run.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Move optional JDBC DistSQL handlers to distribution profiles [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu merged PR #40154:
URL: https://github.com/apache/shardingsphere/pull/40154


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org