You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org> on 2023/10/20 13:12:13 UTC
[Impala-ASF-CR] IMPALA-12481: Fix sorted-run-merger-ir.cc make dependency
Noemi Pap-Takacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20604
Change subject: IMPALA-12481: Fix sorted-run-merger-ir.cc make dependency
......................................................................
IMPALA-12481: Fix sorted-run-merger-ir.cc make dependency
IMPALA-11477 added sorted-run-merger-ir.cc, and incorrectly
added it to the Runtime target, not RuntimeIr.
This patch fixes the issue by adding sorted-run-merger-ir.cc
to RuntimeIr instead in CMakeLists.txt.
Change-Id: Id39cc9613bec60f6308db05dde99f375c68166e0
---
M be/src/runtime/CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/20604/1
--
To view, visit http://gerrit.cloudera.org:8080/20604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id39cc9613bec60f6308db05dde99f375c68166e0
Gerrit-Change-Number: 20604
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12481: Fix sorted-run-merger-ir.cc make dependency
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20604 )
Change subject: IMPALA-12481: Fix sorted-run-merger-ir.cc make dependency
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id39cc9613bec60f6308db05dde99f375c68166e0
Gerrit-Change-Number: 20604
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Oct 2023 09:17:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12481: Fix sorted-run-merger-ir.cc make dependency
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20604 )
Change subject: IMPALA-12481: Fix sorted-run-merger-ir.cc make dependency
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id39cc9613bec60f6308db05dde99f375c68166e0
Gerrit-Change-Number: 20604
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Oct 2023 13:32:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12481: Fix sorted-run-merger-ir.cc make dependency
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20604 )
Change subject: IMPALA-12481: Fix sorted-run-merger-ir.cc make dependency
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/14216/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id39cc9613bec60f6308db05dde99f375c68166e0
Gerrit-Change-Number: 20604
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Oct 2023 13:41:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12481: Fix sorted-run-merger-ir.cc make dependency
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20604 )
Change subject: IMPALA-12481: Fix sorted-run-merger-ir.cc make dependency
......................................................................
IMPALA-12481: Fix sorted-run-merger-ir.cc make dependency
IMPALA-11477 added sorted-run-merger-ir.cc, and incorrectly
added it to the Runtime target, not RuntimeIr.
This patch fixes the issue by adding sorted-run-merger-ir.cc
to RuntimeIr instead in CMakeLists.txt.
Change-Id: Id39cc9613bec60f6308db05dde99f375c68166e0
Reviewed-on: http://gerrit.cloudera.org:8080/20604
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/20604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id39cc9613bec60f6308db05dde99f375c68166e0
Gerrit-Change-Number: 20604
Gerrit-PatchSet: 3
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12481: Fix sorted-run-merger-ir.cc make dependency
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20604 )
Change subject: IMPALA-12481: Fix sorted-run-merger-ir.cc make dependency
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9834/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/20604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id39cc9613bec60f6308db05dde99f375c68166e0
Gerrit-Change-Number: 20604
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Oct 2023 09:17:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12481: Fix sorted-run-merger-ir.cc make dependency
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20604 )
Change subject: IMPALA-12481: Fix sorted-run-merger-ir.cc make dependency
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id39cc9613bec60f6308db05dde99f375c68166e0
Gerrit-Change-Number: 20604
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Oct 2023 16:55:55 +0000
Gerrit-HasComments: No