[GitHub] [arrow] wgtmac commented on a diff in pull request #35146: GH-29781: [C++][Parquet] Switch to use compliant nested types by default

["wgtmac (via GitHub)" <gi...@apache.org>]

wgtmac commented on code in PR #35146:
URL: https://github.com/apache/arrow/pull/35146#discussion_r1168121298


##########
cpp/src/parquet/properties.h:
##########
@@ -819,8 +819,7 @@ class PARQUET_EXPORT ArrowWriterProperties {
           coerce_timestamps_unit_(::arrow::TimeUnit::SECOND),
           truncated_timestamps_allowed_(false),
           store_schema_(false),
-          // TODO: At some point we should flip this.

Review Comment:
   The line 320 in the parquet.rst doc should also be changed.
   ```
      std::shared_ptr<ArrowWriterProperties> arrow_props = ArrowWriterProperties::Builder()
         .enable_deprecated_int96_timestamps() // default False
         ->store_schema() // default False
         ->enable_compliant_nested_types() // default False
         ->build();
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org