You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/29 11:41:06 UTC
[GitHub] [apisix-go-plugin-runner] spacewander opened a new pull request #16: feat: add limit-req demo
spacewander opened a new pull request #16:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/16
Please answer these questions before submitting a pull request
1. Related issues (for new feature or improvement, one should submit an issue first before writing code): Fix #12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander commented on pull request #16: feat: add limit-req demo
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #16:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/16#issuecomment-871016937
Will add it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] codecov-commenter commented on pull request #16: feat: add limit-req demo
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #16:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/16#issuecomment-870521117
# [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/16?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/16?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (501782d) into [master](https://codecov.io/gh/apache/apisix-go-plugin-runner/commit/82c36f230fafc2a58d76fcde553e5535a2f61e87?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (82c36f2) will **decrease** coverage by `0.03%`.
> The diff coverage is `77.77%`.
> :exclamation: Current head 501782d differs from pull request most recent head 02519f8. Consider uploading reports for the commit 02519f8 to get more accurate results
[](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/16?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
- Coverage 78.85% 78.81% -0.04%
==========================================
Files 9 10 +1
Lines 487 505 +18
==========================================
+ Hits 384 398 +14
- Misses 82 84 +2
- Partials 21 23 +2
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/16?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [cmd/go-runner/plugins/limit\_req.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/16/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y21kL2dvLXJ1bm5lci9wbHVnaW5zL2xpbWl0X3JlcS5nbw==) | `77.77% <77.77%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/16?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/16?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [82c36f2...02519f8](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/16?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander merged pull request #16: feat: add limit-req demo
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #16:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] codecov-commenter commented on pull request #16: feat: add limit-req demo
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #16:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/16#issuecomment-870521117
# [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/16?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/16?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (501782d) into [master](https://codecov.io/gh/apache/apisix-go-plugin-runner/commit/82c36f230fafc2a58d76fcde553e5535a2f61e87?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (82c36f2) will **decrease** coverage by `0.03%`.
> The diff coverage is `77.77%`.
> :exclamation: Current head 501782d differs from pull request most recent head 02519f8. Consider uploading reports for the commit 02519f8 to get more accurate results
[](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/16?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
- Coverage 78.85% 78.81% -0.04%
==========================================
Files 9 10 +1
Lines 487 505 +18
==========================================
+ Hits 384 398 +14
- Misses 82 84 +2
- Partials 21 23 +2
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/16?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [cmd/go-runner/plugins/limit\_req.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/16/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y21kL2dvLXJ1bm5lci9wbHVnaW5zL2xpbWl0X3JlcS5nbw==) | `77.77% <77.77%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/16?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/16?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [82c36f2...02519f8](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/16?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org