You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by Ben Peter <bp...@zentropypartners.com> on 2002/04/13 09:35:14 UTC

[Patch] t2: RunData(Factory|Service) Locales

Hi,

Last one for today ;-)

In t2's TurbineRunDataService, the RunData is not populated with a Locale at all.

In RunDataFactory, a Locale is put into the request, but the Locale is not 
obtained so that it is safe for Servlet-API 2.1 and below. I have noticed that 
with the contextPath this had been taken care of (in both classes).

The attached patch makes TRDService put a Locale into the RunData and also 
makes it safe for old servlet APIs. If this safety is not needed/wanted, I 
would suggest that the check is removed both for locales and for the 
contextPath, as using reflection is probably quite expensive.
As far as I can see it makes no sense to treat the two different in this respect.

Cheers,
Ben

-- 
Benjamin Peter                                          +49-69-96244395
Application Engineer                             Moerfelder Landstr. 55
(zentropy:partners)                            60598 Frankfurt, Germany