[GitHub] [activemq-artemis] gtully commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

[GitBox <gi...@apache.org>]

gtully commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses
URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-470455007
 
 
   This looks great. bravo!
   From my perspective it needs two capabilities that would make it a "better bridge" than the 5.x networkConnector.
   
   1) limiting forwarding to consumer demand or credit. Using amqp as the transport would facilitate this to some extent. The flow could be bound to the number of local consumers and their rate. Ideally we would only "forward/bridge" what we think we can consume.
   This is preferable to flowing and flowing back! Having some variation on this, over and above the consumer priority would be a huge win over 5.x.
   Consumer priority is fine when all consumers are fast, however, doing real work in on message will often be slower than forwarding, such that federation becomes a fast consumer. Federation needs to be, in some way limited, to local consumption
   
   2) supporting "at most once forwarding". This is a trade off for sure because something needs to be persisted and typically the application can deal with a duplicate. amqp link recovery would possibly provide an angle here (if it were implemented).
   Core bridge has a sliding window of sequence ids which has value. I think this is one for some future consideration. It is less important than 1 :-)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services