You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/01/05 14:52:00 UTC
[jira] [Commented] (SOLR-12365) Rename Config.java to
XmlConfigFile.java to clarify it's use
[ https://issues.apache.org/jira/browse/SOLR-12365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734926#comment-16734926 ]
ASF subversion and git services commented on SOLR-12365:
--------------------------------------------------------
Commit ca23040baa94b6b4ab833994c2af00bbb2c72f27 in lucene-solr's branch refs/heads/master from David Wayne Smiley
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ca23040 ]
SOLR-12365: Renamed class Config to XmlConfigFile
> Rename Config.java to XmlConfigFile.java to clarify it's use
> ------------------------------------------------------------
>
> Key: SOLR-12365
> URL: https://issues.apache.org/jira/browse/SOLR-12365
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Priority: Minor
>
> Seeing "Config"; I was confused what sort of config it was. Turns out it's a wrapper around an XML document providing some convenience methods around it. It ought to have class javadocs too. XmlConfigFile would be a clearer name IMO.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org