[GitHub] [iceberg] danielcweeks commented on a diff in pull request #5207: Core: Add length arg to FileIO.newInputFile

[GitBox <gi...@apache.org>]

danielcweeks commented on code in PR #5207:
URL: https://github.com/apache/iceberg/pull/5207#discussion_r914268894


##########
gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSOutputFile.java:
##########
@@ -67,6 +67,6 @@ public PositionOutputStream createOrOverwrite() {
 
   @Override
   public InputFile toInputFile() {
-    return new GCSInputFile(storage(), blobId(), gcpProperties(), metrics());
+    return new GCSInputFile(storage(), blobId(), null, gcpProperties(), metrics());

Review Comment:
   Could we just use `GCSInputFile.fromLocation(...)` to avoid calling the constructor with null?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org