You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "guan404ming (via GitHub)" <gi...@apache.org> on 2025/08/19 15:19:49 UTC
[PR] Fix typos in HITL-related code and comments [airflow]
guan404ming opened a new pull request, #54670:
URL: https://github.com/apache/airflow/pull/54670
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
## How
htil and hilt -> hitl (really hard to aware :-)
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix typos in HITL-related code and comments [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #54670:
URL: https://github.com/apache/airflow/pull/54670#discussion_r2285617393
##########
providers/standard/src/airflow/providers/standard/triggers/hitl.py:
##########
@@ -107,7 +107,7 @@ async def run(self) -> AsyncIterator[TriggerEvent]:
)
return
- await sync_to_async(update_htil_detail_response)(
+ await sync_to_async(update_hitl_detail_response)(
Review Comment:
Need to be careful here! Since it depends on the Task SDK version.
So if older Task SDK version is used, this method won't exist! so you probably need a `try..except` unfortunately --- unless this version of Standard provider hasn't been released!
Although at the same time this version isn't usable without Airflow 3.1 so should be ok.
@Lee-W fyi !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix typos in HITL-related code and comments [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W merged PR #54670:
URL: https://github.com/apache/airflow/pull/54670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix typos in HITL-related code and comments [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #54670:
URL: https://github.com/apache/airflow/pull/54670#discussion_r2285754525
##########
providers/standard/src/airflow/providers/standard/triggers/hitl.py:
##########
@@ -107,7 +107,7 @@ async def run(self) -> AsyncIterator[TriggerEvent]:
)
return
- await sync_to_async(update_htil_detail_response)(
+ await sync_to_async(update_hitl_detail_response)(
Review Comment:
> Need to be careful here! Since it depends on the Task SDK version. So if older Task SDK version is used, this method won't exist! so you probably need a try..except unfortunately --- unless this version of Standard provider hasn't been released!
Thanks for pointing it out! I noticed we already have this in code,
https://github.com/apache/airflow/blob/3c4cdf4feb261fddf43fc16c69343b957267e63c/providers/standard/src/airflow/providers/standard/triggers/hitl.py#L22-L23
so I didn’t add `try..except` here. Do you think we should still add it to ensure backward compatibility, or is it fine as is since like you said the feature is not usable before 3.1? (personally prefer the latter one)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix typos in HITL-related code and comments [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #54670:
URL: https://github.com/apache/airflow/pull/54670#discussion_r2285754525
##########
providers/standard/src/airflow/providers/standard/triggers/hitl.py:
##########
@@ -107,7 +107,7 @@ async def run(self) -> AsyncIterator[TriggerEvent]:
)
return
- await sync_to_async(update_htil_detail_response)(
+ await sync_to_async(update_hitl_detail_response)(
Review Comment:
> Need to be careful here! Since it depends on the Task SDK version. So if older Task SDK version is used, this method won't exist! so you probably need a try..except unfortunately --- unless this version of Standard provider hasn't been released!
Thanks for pointing it out! I noticed we already have this in code,
https://github.com/apache/airflow/blob/3c4cdf4feb261fddf43fc16c69343b957267e63c/providers/standard/src/airflow/providers/standard/triggers/hitl.py#L22-L23
so I didn’t add `try..except` here. Do you think we should still add it to ensure backward compatibility, or is it fine as is since like you said the feature is not usable before 3.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix typos in HITL-related code and comments [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #54670:
URL: https://github.com/apache/airflow/pull/54670#discussion_r2286725538
##########
providers/standard/src/airflow/providers/standard/triggers/hitl.py:
##########
@@ -107,7 +107,7 @@ async def run(self) -> AsyncIterator[TriggerEvent]:
)
return
- await sync_to_async(update_htil_detail_response)(
+ await sync_to_async(update_hitl_detail_response)(
Review Comment:
@kaxil Sure! I'll be sure to pay more attention next time. Will we bump min task-sdk version for airflow 3.1, if we're to do that, I don't think we need the try...except. If we're not, I think we'd better add it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix typos in HITL-related code and comments [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #54670:
URL: https://github.com/apache/airflow/pull/54670#discussion_r2287956067
##########
providers/standard/src/airflow/providers/standard/triggers/hitl.py:
##########
@@ -107,7 +107,7 @@ async def run(self) -> AsyncIterator[TriggerEvent]:
)
return
- await sync_to_async(update_htil_detail_response)(
+ await sync_to_async(update_hitl_detail_response)(
Review Comment:
Yeah given we have 3.1 condition, we are fine without try..catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org