You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/11/14 11:34:08 UTC
svn commit: r1895026 - in /pdfbox/branches/2.0/pdfbox/src: main/java/org/apache/pdfbox/text/PDFTextStripper.java test/java/org/apache/pdfbox/util/TestSort.java
Author: tilman
Date: Sun Nov 14 11:34:08 2021
New Revision: 1895026
URL: http://svn.apache.org/viewvc?rev=1895026&view=rev
Log:
PDFBOX-5308: remove quicksort references
Modified:
pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/text/PDFTextStripper.java
pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/util/TestSort.java
Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/text/PDFTextStripper.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/text/PDFTextStripper.java?rev=1895026&r1=1895025&r2=1895026&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/text/PDFTextStripper.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/text/PDFTextStripper.java Sun Nov 14 11:34:08 2021
@@ -500,7 +500,7 @@ public class PDFTextStripper extends Leg
// because the TextPositionComparator is not transitive, but
// JDK7+ enforces transitivity on comparators, we need to use
- // a custom quicksort implementation (which is slower, unfortunately).
+ // a custom mergesort implementation (which is slower, unfortunately).
try
{
Collections.sort(textList, comparator);
Modified: pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/util/TestSort.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/util/TestSort.java?rev=1895026&r1=1895025&r2=1895026&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/util/TestSort.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/util/TestSort.java Sun Nov 14 11:34:08 2021
@@ -31,11 +31,7 @@ public class TestSort extends TestCase
<T extends Comparable<T>> void doTest(T[] input, T[] expected)
{
- List<T> list = Arrays.asList(input.clone());
- QuickSort.sort(list);
- assertTrue(Arrays.equals(list.toArray(new Object[input.length]), expected));
-
- list = Arrays.asList(input.clone());
+ List<T> list = Arrays.asList(input);
IterativeMergeSort.sort(list, new Comparator<T>()
{
@Override