[GitHub] [trafficserver] SolidWallOfCode commented on a diff in pull request #8778: OpenTelemetry Tracer plugin for ATS

[GitBox <gi...@apache.org>]

SolidWallOfCode commented on code in PR #8778:
URL: https://github.com/apache/trafficserver/pull/8778#discussion_r842211815


##########
plugins/experimental/otel_tracer/otel_tracer.cc:
##########
@@ -0,0 +1,363 @@
+/*
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+  http://www.apache.org/licenses/LICENSE-2.0
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+*/
+
+#include <ctype.h>
+#include <stdio.h>
+#include <string.h>
+#include <iostream>
+#include <vector>
+#include <unistd.h>
+#include <getopt.h>
+
+#include "ts/ts.h"
+
+#define PLUGIN_NAME "otel_tracer"
+
+#include "tracer_common.h"
+namespace trace    = opentelemetry::trace;
+namespace nostd    = opentelemetry::nostd;
+namespace sdktrace = opentelemetry::sdk::trace;
+
+static int
+close_txn(TSCont contp, TSEvent event, void *edata)
+{
+  int retval = 0;
+  TSMBuffer buf;
+  TSMLoc hdr_loc;
+
+  ExtraRequestData *req_data = static_cast<ExtraRequestData *>(TSContDataGet(contp));

Review Comment:
   Style - use `auto` here since the type is already in the cast.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org