You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2021/03/26 21:37:35 UTC

[GitHub] [avro] subhashb opened a new pull request #1158: AVRO-3097 Run Schema Compatibility checks as part of Unittest

subhashb opened a new pull request #1158:
URL: https://github.com/apache/avro/pull/1158


   Test methods in `test_compatibility.py` were being ignored in `unittest` runs because they were not connected to `unittest.TestCase`.
   
   This commit encloses the test cases within a class deriving from `unittest.TestCase` and also changes assert statements to be in compliance with `unittest`.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title.
     - https://issues.apache.org/jira/browse/AVRO-3097
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     NA
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] subhashb closed pull request #1158: AVRO-3097 Run Schema Compatibility checks as part of Unittest

Posted by GitBox <gi...@apache.org>.
subhashb closed pull request #1158:
URL: https://github.com/apache/avro/pull/1158


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] subhashb commented on pull request #1158: AVRO-3097 Run Schema Compatibility checks as part of Unittest

Posted by GitBox <gi...@apache.org>.
subhashb commented on pull request #1158:
URL: https://github.com/apache/avro/pull/1158#issuecomment-808558100


   The `compatibility` module is not active right now, so closing until it is ready for prime time again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org