You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/03/23 14:39:38 UTC
Re: Review Request 63733: Don't print full usage for invocation
errors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63733/
-----------------------------------------------------------
(Updated March 23, 2018, 2:39 p.m.)
Review request for mesos.
Repository: mesos
Description
-------
Don't print full usage for invocation errors.
Diffs (updated)
-----
src/master/main.cpp 3d93fd4825f0f58fce664379e3337a61bb93aa0a
src/slave/main.cpp 67437272ee538dd2eae44f5664630cf7c930c23f
Diff: https://reviews.apache.org/r/63733/diff/2/
Changes: https://reviews.apache.org/r/63733/diff/1-2/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 63733: Don't print full usage for invocation
errors.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63733/#review199894
-----------------------------------------------------------
PASS: Mesos patch 63733 was successfully built and tested.
Reviews applied: `['63733']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63733
- Mesos Reviewbot Windows
On March 23, 2018, 2:39 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63733/
> -----------------------------------------------------------
>
> (Updated March 23, 2018, 2:39 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Don't print full usage for invocation errors.
>
> The current usage string for `mesos-master` comes in at 399 lines, and for `mesos-agent` at 685 lines. Printing such a wall of text will overflow almost any terminal window, making it necessary to scroll up to see the actual error when invoking mesos with an incorrect command line.
>
>
> Diffs
> -----
>
> src/master/main.cpp 3d93fd4825f0f58fce664379e3337a61bb93aa0a
> src/slave/main.cpp 67437272ee538dd2eae44f5664630cf7c930c23f
>
>
> Diff: https://reviews.apache.org/r/63733/diff/2/
>
>
> Testing
> -------
>
> Started `mesos-agent` and `mesos-master` with an incorrect command-line.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63733: Don't print full usage for invocation
errors.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63733/#review199890
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot
On March 23, 2018, 10:39 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63733/
> -----------------------------------------------------------
>
> (Updated March 23, 2018, 10:39 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Don't print full usage for invocation errors.
>
> The current usage string for `mesos-master` comes in at 399 lines, and for `mesos-agent` at 685 lines. Printing such a wall of text will overflow almost any terminal window, making it necessary to scroll up to see the actual error when invoking mesos with an incorrect command line.
>
>
> Diffs
> -----
>
> src/master/main.cpp 3d93fd4825f0f58fce664379e3337a61bb93aa0a
> src/slave/main.cpp 67437272ee538dd2eae44f5664630cf7c930c23f
>
>
> Diff: https://reviews.apache.org/r/63733/diff/2/
>
>
> Testing
> -------
>
> Started `mesos-agent` and `mesos-master` with an incorrect command-line.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63733: Don't print full usage for invocation
errors.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63733/#review200116
-----------------------------------------------------------
Ship it!
Thanks for this Benno - had annoyed me for so long already :)
- Till Toenshoff
On March 23, 2018, 2:39 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63733/
> -----------------------------------------------------------
>
> (Updated March 23, 2018, 2:39 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-8728
> https://issues.apache.org/jira/browse/MESOS-8728
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The current usage string for `mesos-master` comes in at 399 lines, and
> for `mesos-agent` at 685 lines. Printing such a wall of text will
> overflow almost any terminal window, making it necessary to scroll up
> to see the actual error when invoking mesos with an incorrect command
> line.
>
>
> Diffs
> -----
>
> src/master/main.cpp 3d93fd4825f0f58fce664379e3337a61bb93aa0a
> src/slave/main.cpp 67437272ee538dd2eae44f5664630cf7c930c23f
>
>
> Diff: https://reviews.apache.org/r/63733/diff/2/
>
>
> Testing
> -------
>
> Started `mesos-agent` and `mesos-master` with an incorrect command-line.
>
> ```
> bevers@poincare:~/mesos/worktrees/usage/build$ ./src/mesos-master --foo
> Failed to load unknown flag 'foo'
>
> See `mesos-master --help` for a list of supported flags.
> bevers@poincare:~/mesos/worktrees/usage/build$ ./src/mesos-master
> I0323 17:33:45.526222 19899 main.cpp:246] Build: 2018-03-22 17:04:18 by bevers
> I0323 17:33:45.526304 19899 main.cpp:247] Version: 1.6.0
> I0323 17:33:45.536743 19899 main.cpp:346] Using 'HierarchicalDRF' allocator
> E0323 17:33:45.536763 19899 main.cpp:361] EXIT with status 1: --work_dir needed for replicated log based registry
> ```
>
>
> Thanks,
>
> Benno Evers
>
>