You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/20 18:10:13 UTC

[GitHub] [kafka] hachikuji opened a new pull request #10168: MINOR: Remove redundant log close in `KafkaRaftClient`

hachikuji opened a new pull request #10168:
URL: https://github.com/apache/kafka/pull/10168


   This patch fixes a small shutdown bug. Current logic closes the log twice: once in `KafkaRaftClient`, and once in `RaftManager`. This can lead to errors like the following:
   
   ```
   [2021-02-18 18:35:12,643] WARN  (kafka.utils.CoreUtils$)
   java.nio.channels.ClosedChannelException
           at java.base/sun.nio.ch.FileChannelImpl.ensureOpen(FileChannelImpl.java:150)
           at java.base/sun.nio.ch.FileChannelImpl.force(FileChannelImpl.java:452)
           at org.apache.kafka.common.record.FileRecords.flush(FileRecords.java:197)
           at org.apache.kafka.common.record.FileRecords.close(FileRecords.java:204)
           at kafka.log.LogSegment.$anonfun$close$4(LogSegment.scala:592)
           at kafka.utils.CoreUtils$.swallow(CoreUtils.scala:68)
           at kafka.log.LogSegment.close(LogSegment.scala:592)
           at kafka.log.Log.$anonfun$close$4(Log.scala:1038)
           at kafka.log.Log.$anonfun$close$4$adapted(Log.scala:1038)
           at scala.collection.IterableOnceOps.foreach(IterableOnce.scala:563)
           at scala.collection.IterableOnceOps.foreach$(IterableOnce.scala:561)
           at scala.collection.AbstractIterable.foreach(Iterable.scala:919)
           at kafka.log.Log.$anonfun$close$3(Log.scala:1038)
           at kafka.log.Log.close(Log.scala:2433)
           at kafka.raft.KafkaMetadataLog.close(KafkaMetadataLog.scala:295)
           at kafka.raft.KafkaRaftManager.shutdown(RaftManager.scala:150)
   ```
   
   I have tended to view `RaftManager` as owning the lifecycle of the log, so I removed the extra call to close in `KafkaRaftClient`.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji merged pull request #10168: MINOR: Remove redundant log close in `KafkaRaftClient`

Posted by GitBox <gi...@apache.org>.

hachikuji merged pull request #10168:
URL: https://github.com/apache/kafka/pull/10168


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji commented on pull request #10168: MINOR: Remove redundant log close in `KafkaRaftClient`

Posted by GitBox <gi...@apache.org>.

hachikuji commented on pull request #10168:
URL: https://github.com/apache/kafka/pull/10168#issuecomment-782745887


   Merging to trunk and 2.8.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org