[GitHub] [brooklyn-dist] ahgittin commented on a change in pull request #149: mark these scripts as bash, they don't work under zsh

[GitBox <gi...@apache.org>]

ahgittin commented on a change in pull request #149: mark these scripts as bash, they don't work under zsh
URL: https://github.com/apache/brooklyn-dist/pull/149#discussion_r354277649
 
 

 ##########
 File path: dist/licensing/generate-license-and-notice.sh
 ##########
 @@ -146,6 +148,15 @@ if [ ! -z "$LIBRARIES" ] ; then
 fi
 
 process_dependencies() {
+  echo running mvn license-audit-maven-plugin:notices
+  echo mvn -X org.heneveld.maven:license-audit-maven-plugin:notices \
+        -DlicensesPreferred=Apache-2.0,Apache,EPL-1.0,BSD-2-Clause,BSD-3-Clause,CDDL-1.1,CDDL-1.0,CDDL \
+        -DoverridesFile=$TEMP_METADATA_FILE \
+        -DoutputYaml=true \
+        -DoutputFile=$TEMP_NOTICE_DATA_FILE \
+        $@
 
 Review comment:
   i left it as it's useful ... happy to remove (ideally would be `set +e` or `+x` ? i can never remember the command echo ... but this is only run a few times a year to update the license files so not a big deal either way imo

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services