You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/03/14 12:07:50 UTC

[GitHub] [rocketmq] duhenglucky commented on pull request #3943: [#3942]If both acl and message trace are enabled and the default topic RMQ_SYS_TRACE_TOPIC is used for message trace, you don't need to add the PUB permission of RMQ_SYS_TRACE_TOPIC topic to the acl config.

duhenglucky commented on pull request #3943:
URL: https://github.com/apache/rocketmq/pull/3943#issuecomment-1066708161


   > It may be better if we skip checks on specified topics in `BrokerRpcHook` where we can get trace topic configs.
   
   but if we used  BrokerRpcHook to skip the tracing topic validation, we must add some validation logic in the broker, otherwise in ACL module, so how about only skipping the default tracing topic， and adding a description for the customized tracing  topic， just letting the admin add  permission for customized tracing  topic


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org