You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2023/01/11 14:51:30 UTC
[GitHub] [maven-integration-testing] cstamas opened a new pull request, #228: Update Jetty to latest Java8 capable version
cstamas opened a new pull request, #228:
URL: https://github.com/apache/maven-integration-testing/pull/228
Update Jetty to latest 9.4.50, last Java 8 capable version. This will simplify our lives in future, to make jump to later versions (that are Java 11+).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #228: [MNG-7665] Update Jetty to latest Java8 capable version
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #228:
URL: https://github.com/apache/maven-integration-testing/pull/228#discussion_r1067321280
##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4470AuthenticatedDeploymentToProxyTest.java:
##########
@@ -92,7 +89,7 @@ public void handle( String target, Request baseRequest, HttpServletRequest reque
if ( auth != null )
{
auth = auth.substring( auth.indexOf( ' ' ) + 1 ).trim();
- auth = B64Code.decode( auth, StandardCharsets.US_ASCII.name() );
+ auth = new String( java.util.Base64.getDecoder().decode( auth ), StandardCharsets.US_ASCII );
Review Comment:
Why not `import java.util.Base64`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] cstamas merged pull request #228: [MNG-7665] Update Jetty to latest Java8 capable version
Posted by GitBox <gi...@apache.org>.
cstamas merged PR #228:
URL: https://github.com/apache/maven-integration-testing/pull/228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #228: [MNG-7665] Update Jetty to latest Java8 capable version
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #228:
URL: https://github.com/apache/maven-integration-testing/pull/228#discussion_r1067419804
##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4470AuthenticatedDeploymentToProxyTest.java:
##########
@@ -92,7 +89,7 @@ public void handle( String target, Request baseRequest, HttpServletRequest reque
if ( auth != null )
{
auth = auth.substring( auth.indexOf( ' ' ) + 1 ).trim();
- auth = B64Code.decode( auth, StandardCharsets.US_ASCII.name() );
+ auth = new String( java.util.Base64.getDecoder().decode( auth ), StandardCharsets.US_ASCII );
Review Comment:
😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] cstamas commented on a diff in pull request #228: [MNG-7665] Update Jetty to latest Java8 capable version
Posted by GitBox <gi...@apache.org>.
cstamas commented on code in PR #228:
URL: https://github.com/apache/maven-integration-testing/pull/228#discussion_r1067347100
##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4470AuthenticatedDeploymentToProxyTest.java:
##########
@@ -92,7 +89,7 @@ public void handle( String target, Request baseRequest, HttpServletRequest reque
if ( auth != null )
{
auth = auth.substring( auth.indexOf( ' ' ) + 1 ).trim();
- auth = B64Code.decode( auth, StandardCharsets.US_ASCII.name() );
+ auth = new String( java.util.Base64.getDecoder().decode( auth ), StandardCharsets.US_ASCII );
Review Comment:
no special reason, I believe at one point both classes were present (Jetty deprecated B64code and j.u.Base64) and my IDE just choose to fully name it? Should I add it to import?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org