You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "thisdudeiknew (via GitHub)" <gi...@apache.org> on 2023/07/11 18:03:49 UTC

[PR] Fix RollingFileManager and FileRenameAction to correctly propagate sy… (logging-log4j2)

thisdudeiknew opened a new pull request, #1549:
URL: https://github.com/apache/logging-log4j2/pull/1549

   …nchronous action failures
   
   [A clear and concise description of what the pull request is for along with a reference to the associated issue IDs, if they exist.]
   
   ## Checklist
   
   * Base your changes on `2.x` branch if you are targeting Log4j 2; use `main` otherwise
   * `./mvnw verify` succeeds (if it fails due to code formatting issues reported by Spotless, simply run `./mvnw spotless:apply` and retry)
   * Non-trivial changes contain an entry file in the `src/changelog/.2.x.x` directory
   * Tests for the changes are provided
   * [Commits are signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) (optional, but highly recommended)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Issue 1445 - Fix RollingFileManager and FileRenameAction (logging-log4j2)

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #1549:
URL: https://github.com/apache/logging-log4j2/pull/1549#issuecomment-1632973469

   @thisdudeiknew: it's a flaky test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Issue 1445 - Fix RollingFileManager and FileRenameAction (logging-log4j2)

Posted by "thisdudeiknew (via GitHub)" <gi...@apache.org>.
thisdudeiknew commented on PR #1549:
URL: https://github.com/apache/logging-log4j2/pull/1549#issuecomment-1632837633

   Is someone available to help me diagnose the Ubuntu build failure?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Issue 1445 - Fix RollingFileManager and FileRenameAction (logging-log4j2)

Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on PR #1549:
URL: https://github.com/apache/logging-log4j2/pull/1549#issuecomment-1748868754

   Thanks so much for the fix @thisdudeiknew, much appreciated! :bow: Merging it...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Issue 1445 - Fix RollingFileManager and FileRenameAction (logging-log4j2)

Posted by "vy (via GitHub)" <gi...@apache.org>.
vy merged PR #1549:
URL: https://github.com/apache/logging-log4j2/pull/1549


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org