You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2019/04/03 21:14:55 UTC

[Impala-ASF-CR] IMPALA-8380: Bump Postgres JDBC driver version to 9.4

Lars Volker has uploaded a new patch set (#2) to the change originally created by Laszlo Gaal. ( http://gerrit.cloudera.org:8080/12894 )

Change subject: IMPALA-8380: Bump Postgres JDBC driver version to 9.4
......................................................................

IMPALA-8380: Bump Postgres JDBC driver version to 9.4

Testing on Ubuntu 18.04 with PostgreSQL 10 (the default for the OS)
revealed that HMS fails to start with the existing v9.0 Postgres JDBC
driver.

The patch bumps the driver version to 42.2.5, which allows HMS to start
with PostreSQL 10.

The updated driver turned out to be pickier about the JDBC connection
strings, so these had to be updated in the various sentry-site-*.xml
templates. The old connection strings had two problems:
- trailing slashes in the URIs,
- a ';create=true' additional parameter, which seems to be a remnant of
  a Derby connection string. The previous driver accepted
  (and probably ignored) this, but the new one rejects any extension
  after the database name.

To ensure that existing platforms are not broken, core tests were run:
- in Docker for CentOS 6, CentOS 7 and Ubuntu 16.04
- on Amazon VMs for CentOS 6.4 and CentOS 7.4
- Ubuntu 18.04 was tested on a VM and in Docker as well.

Change-Id: Ica5423c18a9f8346dda7dae617b1764638b57b6c
---
M bin/create-test-configuration.sh
M bin/impala-config.sh
M fe/pom.xml
M fe/src/test/resources/sentry-site.xml.template
M fe/src/test/resources/sentry-site_no_oo.xml.template
M fe/src/test/resources/sentry-site_oo.xml.template
M fe/src/test/resources/sentry-site_oo_nogrant.xml.template
M impala-parent/pom.xml
8 files changed, 14 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/12894/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12894
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ica5423c18a9f8346dda7dae617b1764638b57b6c
Gerrit-Change-Number: 12894
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>