[GitHub] [openwhisk-runtime-go] falkzoll commented on a change in pull request #150: Extend `proxy -version` to also show the go runtime version.

[GitBox <gi...@apache.org>]

falkzoll commented on a change in pull request #150:
URL: https://github.com/apache/openwhisk-runtime-go/pull/150#discussion_r674140856



##########
File path: main/proxy.go
##########
@@ -49,7 +50,7 @@ func main() {
 
 	// show version number
 	if *version {
-		fmt.Printf("OpenWhisk ActionLoop Proxy v%s\n", openwhisk.Version)
+		fmt.Printf("OpenWhisk ActionLoop Proxy v%s, built with %s\n", openwhisk.Version, runtime.Version())

Review comment:
       Right now I did not mention `Go runtime version` in the string as the string returned by runtime.version() already contains a leading 'go'.
   ```
   OpenWhisk ActionLoop Proxy v1.17.1, built with go1.15.3
   ```
   
   With the proposed change it will look like this:
   ```
   OpenWhisk ActionLoop Proxy v1.17.1, built with Go runtime version go1.15.3
   ```
   Optionally the double `go` in the output can be avoided:
   ```
   OpenWhisk ActionLoop Proxy v1.17.1, built with go1.15.3 runtime
   ```
   What do you think?
   I will then change the message accordingly.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org